From: Peter Zijlstra <peterz@infradead.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, konrad.wilk@oracle.com,
catalin.marinas@arm.com, arnd@arndb.de, olof@lixom.net,
linux@arm.linux.org.uk, Ian.Campbell@citrix.com,
will.deacon@arm.com, marc.zyngier@arm.com, mingo@redhat.com
Subject: Re: [PATCH v6 2/5] kernel: missing include in cputime.c
Date: Thu, 27 Jun 2013 16:12:09 +0200 [thread overview]
Message-ID: <20130627141209.GB29209@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1372341272-12512-2-git-send-email-stefano.stabellini@eu.citrix.com>
On Thu, Jun 27, 2013 at 02:54:29PM +0100, Stefano Stabellini wrote:
> steal_account_process_tick calls paravirt_steal_clock, but paravirt.h is
> currently missing amoung the included header files.
> Add include asm/paravirt.h ifdef CONFIG_PARAVIRT.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: mingo@redhat.com
> CC: peterz@infradead.org
>
> Changes in v5:
> - add ifdef CONFIG_PARAVIRT.
> ---
> kernel/sched/cputime.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index cc2dc3ee..317a578 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -5,7 +5,9 @@
> #include <linux/static_key.h>
> #include <linux/context_tracking.h>
> #include "sched.h"
> -
> +#ifdef CONFIG_PARAVIRT
> +#include <asm/paravirt.h>
> +#endif
Why isn't that CONFIG stuff inside the header instead of around it?
next prev parent reply other threads:[~2013-06-27 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 13:53 [PATCH v6 0/5] xen/arm/arm64: CONFIG_PARAVIRT and stolen ticks accounting Stefano Stabellini
2013-06-27 13:54 ` [PATCH v6 1/5] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c Stefano Stabellini
2013-06-27 13:54 ` [PATCH v6 2/5] kernel: missing include in cputime.c Stefano Stabellini
2013-06-27 14:12 ` Peter Zijlstra [this message]
2013-06-27 14:17 ` Ingo Molnar
2013-06-27 14:43 ` Stefano Stabellini
2013-06-27 13:54 ` [PATCH v6 3/5] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops Stefano Stabellini
2013-06-27 13:54 ` [PATCH v6 4/5] arm64: " Stefano Stabellini
2013-06-27 13:54 ` [PATCH v6 5/5] xen/arm: account for stolen ticks Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627141209.GB29209@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Ian.Campbell@citrix.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=olof@lixom.net \
--cc=stefano.stabellini@eu.citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox