From: Andy Whitcroft <apw@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
"mszeredi@suse.cz" <mszeredi@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/2] overlayfs -- follow change to do_splice_direct interface
Date: Thu, 27 Jun 2013 18:22:47 +0100 [thread overview]
Message-ID: <20130627172247.GC5467@bark> (raw)
In-Reply-To: <CAJfpegsYPDi2oxt0WKHFrwYBjrk6-SNj_owghtOGxqyVVG45uQ@mail.gmail.com>
On Thu, Jun 27, 2013 at 06:37:45PM +0200, Miklos Szeredi wrote:
> Thanks for the patches, Andy. I already pushed a similar set of fixes
> to overlayfs.current (.v18) and to .v17 for the dentry_open() refcount
> fix.
Bah so you did, that'll teach me for waiting for them to be tested.
> It is interesting how many people end up fixing this the wrong way ;)
>
> Hint: how will the file offsets advance?
Interesting I got bluffed in by the original implementation which
reloaded the source pos each time.
-apw
prev parent reply other threads:[~2013-06-27 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 16:26 [PATCH 0/3] overlayfs fixes for v3.8 and later base Andy Whitcroft
2013-06-27 16:26 ` [PATCH 1/1] overlayfs -- ovl_path_open should not take path reference Andy Whitcroft
2013-06-27 16:26 ` [PATCH 1/2] vfs: export do_splice_direct() to modules -- fix Andy Whitcroft
2013-06-27 16:26 ` [PATCH 2/2] overlayfs -- follow change to do_splice_direct interface Andy Whitcroft
2013-06-27 16:37 ` Miklos Szeredi
2013-06-27 17:22 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627172247.GC5467@bark \
--to=apw@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox