From: Russell King <rmk@arm.linux.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] delayed kobject release: help find buggy code
Date: Thu, 27 Jun 2013 19:15:46 +0100 [thread overview]
Message-ID: <20130627181545.GC12530@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20130627153612.GA25244@kroah.com>
On Thu, Jun 27, 2013 at 08:36:12AM -0700, Greg KH wrote:
> On Thu, Jun 27, 2013 at 03:06:14PM +0100, Russell King wrote:
> > Greg,
> >
> > This is an updated copy of my delayed kobject release debugging patch
> > from 2011, which I notice hasn't hit mainline. Please consider merging
> > this so that driver authors and subsystem maintainers have a way to test
> > code for kobject refcounting errors.
> >
> > Moreover, please also consider whether to make the debug option default
> > to 'y' when CONFIG_DEBUG_KERNEL is enabled.
>
> Nice, I had forgotten about this code. Have you run it in a while to
> see if things still work well?
Not since I originally posted it, and had other people use it to find
bugs a few years ago. Since then it's virtually unchanged - the changes
are basically introducing the config option rather than the fixed #define
in the header file enabling it, and changing a pr_info() to a pr_debug().
The patch applied with just a few lines of offset too, and I did build
test it before sending in both enabled and disabled states.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
prev parent reply other threads:[~2013-06-27 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 14:06 [PATCH] delayed kobject release: help find buggy code Russell King
2013-06-27 15:36 ` Greg KH
2013-06-27 18:15 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627181545.GC12530@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox