public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: gregkh@linuxfoundation.org, shawn.guo@linaro.org,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows
Date: Fri, 28 Jun 2013 09:30:13 +0200	[thread overview]
Message-ID: <20130628073013.GJ27010@pengutronix.de> (raw)
In-Reply-To: <1372390325-7566-5-git-send-email-festevam@gmail.com>

On Fri, Jun 28, 2013 at 12:32:05AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Later in ipu_dp_get() the index of the flow array is calculated by:
> flow >> 1
> 
> So adjust its maximum to IPUV3_NUM_FLOWS << 1.
Maybe squash this into patch 4?

Uwe
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> index 3bdff6af..ae2c199 100644
> --- a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> +++ b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> @@ -282,7 +282,7 @@ struct ipu_dp *ipu_dp_get(struct ipu_soc *ipu, unsigned int flow)
>  	struct ipu_dp_priv *priv = ipu->dp_priv;
>  	struct ipu_dp *dp;
>  
> -	if (flow > 5)
> +	if (flow > IPUV3_NUM_FLOWS << 1)
>  		return ERR_PTR(-EINVAL);
>  
>  	if (flow & 1)
> -- 
> 1.8.1.2
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2013-06-28  7:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28  3:32 [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id Fabio Estevam
2013-06-28  3:32 ` [PATCH 2/5] imx-drm: ipu-dp: Check the return value of devm_kzalloc() Fabio Estevam
2013-06-28  3:32 ` [PATCH 3/5] imx-drm: ipu-dp: Remove unneeded braces Fabio Estevam
2013-06-28  3:32 ` [PATCH 4/5] imx-drm: ipu-dp: Introduce IPUV3_NUM_FLOWS Fabio Estevam
2013-06-28  3:32 ` [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows Fabio Estevam
2013-06-28  7:30   ` Uwe Kleine-König [this message]
2013-06-28 13:25     ` Fabio Estevam
2013-06-28 13:53   ` Philipp Zabel
2013-06-28 14:09     ` Fabio Estevam
2013-06-28  7:29 ` [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id Uwe Kleine-König
2013-06-28 14:43   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628073013.GJ27010@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox