From: Denys Vlasenko <vda.linux@googlemail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
James Hogan <james.hogan@imgtec.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Daney <ddaney@caviumnetworks.com>,
David Daney <ddaney.cavm@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
David Daney <david.daney@cavium.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] kernel/signal.c: fix BUG_ON with SIG128 (MIPS)
Date: Fri, 28 Jun 2013 22:09:21 +0200 [thread overview]
Message-ID: <201306282209.21839.vda.linux@googlemail.com> (raw)
In-Reply-To: <20130626165900.GF7171@linux-mips.org>
On Wednesday 26 June 2013 18:59, Ralf Baechle wrote:
> On Wed, Jun 26, 2013 at 06:14:52PM +0200, Oleg Nesterov wrote:
>
> > Or simply remove the BUG_ON(), this can equally confuse wait(status).
> > 128 & 0x7f == 0.
> >
> > Still I think it would be better to change _NSIG on mips.
>
> If it was that easy. That's going to outright break binary compatibility,
> see kernel/signal.c:
>
> SYSCALL_DEFINE4(rt_sigprocmask, int, how, sigset_t __user *, nset,
> sigset_t __user *, oset, size_t, sigsetsize)
> {
> sigset_t old_set, new_set;
> int error;
>
> /* XXX: Don't preclude handling different sized sigset_t's. */
> if (sigsetsize != sizeof(sigset_t))
> return -EINVAL;
>
> There are several more more syscalls performing tests like the above.
Reducing _NSIG to 127 (or 126) doesn't change sigset_t, so should be fine wrt above.
next prev parent reply other threads:[~2013-06-28 20:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 13:39 [PATCH v3] kernel/signal.c: fix BUG_ON with SIG128 (MIPS) James Hogan
2013-06-21 15:59 ` David Daney
2013-06-21 16:12 ` Ralf Baechle
2013-06-21 20:22 ` Oleg Nesterov
2013-06-21 20:45 ` David Daney
2013-06-22 19:09 ` Oleg Nesterov
2013-06-24 9:10 ` James Hogan
2013-06-25 21:40 ` Andrew Morton
2013-06-25 22:13 ` James Hogan
2013-06-26 11:07 ` James Hogan
2013-06-26 16:01 ` Ralf Baechle
2013-06-26 16:14 ` Oleg Nesterov
2013-06-26 16:59 ` Ralf Baechle
2013-06-26 17:15 ` Oleg Nesterov
2013-06-28 12:07 ` James Hogan
2013-06-28 17:55 ` Oleg Nesterov
2013-06-28 20:09 ` Denys Vlasenko [this message]
2013-06-24 9:26 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306282209.21839.vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=dhowells@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).