[PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()
@ 2013-06-26  1:57 Wei Yongjun
  2013-06-26 13:06 ` Nishanth Menon
  2013-06-29  1:42 ` [PATCH -next] " Anton Vorontsov
  0 siblings, 2 replies; 5+ messages in thread
From: Wei Yongjun @ 2013-06-26  1:57 UTC (permalink / raw)
  To: anton, dwmw2, khilman, andrii.tseglytskyi, nm, jean.pihet, tony
  Cc: yongjun_wei, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/power/avs/smartreflex.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index db9973b..c26acfc 100644
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev)
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
-	if (IS_ERR(sr_info->base)) {
-		dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
+	if (IS_ERR(sr_info->base))
 		return PTR_ERR(sr_info->base);
-	}
 
 	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()
  2013-06-26  1:57 [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() Wei Yongjun
@ 2013-06-26 13:06 ` Nishanth Menon
       [not found]   ` <877gh8nbpm.fsf@linaro.org>
  2013-06-29  1:42 ` [PATCH -next] " Anton Vorontsov
  1 sibling, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2013-06-26 13:06 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: anton, dwmw2, khilman, andrii.tseglytskyi, jean.pihet, tony,
	yongjun_wei, linux-kernel, linux-omap

On 09:57-20130626, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/power/avs/smartreflex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..c26acfc 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> -	if (IS_ERR(sr_info->base)) {
> -		dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
> +	if (IS_ERR(sr_info->base))
>  		return PTR_ERR(sr_info->base);
> -	}
>  
>  	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>  
> 
Acked-by: Nishanth Menon <nm@ti.com>
-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <877gh8nbpm.fsf@linaro.org>]

* [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()
       [not found]   ` <877gh8nbpm.fsf@linaro.org>
@ 2013-07-12  4:59     ` Wei Yongjun
  2013-08-05 16:25       ` Kevin Hilman
  0 siblings, 1 reply; 5+ messages in thread
From: Wei Yongjun @ 2013-07-12  4:59 UTC (permalink / raw)
  To: khilman
  Cc: nm, anton, dwmw2, andrii.tseglytskyi, jean.pihet, tony,
	yongjun_wei, linux-kernel, linux-omap, linux-pm

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Nishanth Menon <nm@ti.com>
---
cc to linux-pm with Nishanth Menon's ACK
---
 drivers/power/avs/smartreflex.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index db9973b..c26acfc 100644
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev)
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
-	if (IS_ERR(sr_info->base)) {
-		dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
+	if (IS_ERR(sr_info->base))
 		return PTR_ERR(sr_info->base);
-	}
 
 	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()
  2013-07-12  4:59     ` [PATCH RESEND] " Wei Yongjun
@ 2013-08-05 16:25       ` Kevin Hilman
  0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2013-08-05 16:25 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: nm, anton, dwmw2, andrii.tseglytskyi, jean.pihet, tony,
	yongjun_wei, linux-kernel, linux-omap, linux-pm

Wei Yongjun <weiyj.lk@gmail.com> writes:

> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> Acked-by: Nishanth Menon <nm@ti.com>
> ---
> cc to linux-pm with Nishanth Menon's ACK

Thanks, queued for v3.12.

Kevin

> ---
>  drivers/power/avs/smartreflex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..c26acfc 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> -	if (IS_ERR(sr_info->base)) {
> -		dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
> +	if (IS_ERR(sr_info->base))
>  		return PTR_ERR(sr_info->base);
> -	}
>  
>  	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>  

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()
  2013-06-26  1:57 [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() Wei Yongjun
  2013-06-26 13:06 ` Nishanth Menon
@ 2013-06-29  1:42 ` Anton Vorontsov
  1 sibling, 0 replies; 5+ messages in thread
From: Anton Vorontsov @ 2013-06-29  1:42 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: dwmw2, khilman, andrii.tseglytskyi, nm, jean.pihet, tony,
	yongjun_wei, linux-kernel

On Wed, Jun 26, 2013 at 09:57:14AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---

The patch does not apply to the battery-2.6.git tree... :-/

(In the patch I see "sr_info", but in the current driver there is just
"sr".)

>  drivers/power/avs/smartreflex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..c26acfc 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> -	if (IS_ERR(sr_info->base)) {
> -		dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
> +	if (IS_ERR(sr_info->base))
>  		return PTR_ERR(sr_info->base);
> -	}
>  
>  	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>  
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-08-05 16:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26  1:57 [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() Wei Yongjun
2013-06-26 13:06 ` Nishanth Menon
     [not found]   ` <877gh8nbpm.fsf@linaro.org>
2013-07-12  4:59     ` [PATCH RESEND] " Wei Yongjun
2013-08-05 16:25       ` Kevin Hilman
2013-06-29  1:42 ` [PATCH -next] " Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox