From: Felipe Balbi <balbi@ti.com>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Felipe Balbi <balbi@ti.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
George Cherian <george.cherian@ti.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <linux-omap@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available
Date: Sun, 30 Jun 2013 11:20:54 +0300 [thread overview]
Message-ID: <20130630082054.GA2634@arwen.pp.htv.fi> (raw)
In-Reply-To: <20130628200601.GK3523@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
Hi,
On Fri, Jun 28, 2013 at 10:06:01PM +0200, Michael Grzeschik wrote:
> > > > > > > > right, but in DT you will define both instances and each instance will
> > > > > > > > have a seaparate snps,maximum_speed attribute :-)
> > > > > > > >
> > > > > > > > I'm now considering if we should make maximum_speed a generic attribute,
> > > > > > > > Kishon ? Alex ? Alan ?
> > > > > > > >
> > > > > > > > anyone else needs such thing ?
> > > > > > >
> > > > > > > We have a force-full-speed attibute for chipidea on the way. This
> > > > > > > maximum_speed looks like a more generic alternative. Michael, what say
> > > > > > > you?
> > > > > >
> > > > > > The maximum_speed attribute sounds more reasonable. I will change my
> > > > > > patch to it.
> > > > >
> > > > > thanks, perhaps we can add a generic helper in udc-core or usb-common ?
> > > >
> > > > As this function is not only udc specific, this should go into usb-common.
> > > > But right, we should go with a helper here. I will write one in addition
> > > > to my full-speed patch as first user of it.
> > >
> > > alright, thanks :-)
> >
> > Michael, if you need any help with patching in maximum_speed attribute,
> > let me know as I have some time to work on that part.
>
> Feel free to begin with anything. I am currently short on time.
> Do you need some pointers?
not, really v1 will come on monday.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-30 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 9:29 [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available George Cherian
2013-06-26 10:16 ` Felipe Balbi
2013-06-26 12:07 ` George Cherian
2013-06-26 12:12 ` Felipe Balbi
2013-06-26 12:46 ` Alexander Shishkin
2013-06-27 6:14 ` Michael Grzeschik
2013-06-27 6:35 ` Felipe Balbi
2013-06-27 7:24 ` Michael Grzeschik
2013-06-27 7:30 ` Felipe Balbi
2013-06-28 18:00 ` Felipe Balbi
2013-06-28 20:06 ` Michael Grzeschik
2013-06-30 8:20 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130630082054.GA2634@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgr@pengutronix.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox