From: 张忠山 <zzs0213@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] let kbuild mkdir for dir/file.o
Date: Sun, 30 Jun 2013 17:02:03 +0800 [thread overview]
Message-ID: <20130630090203.GA6557@greatfirst.com> (raw)
In-Reply-To: <51CE11C2.5020406@suse.cz>
> > # $(obj-dirs) is a list of directories that contain object files
> > -obj-dirs := $(dir $(multi-objs) $(subdir-obj-y))
> > +__subdir-obj-y := $(foreach o,$(obj-y),$(if $(filter-out $(o),$(notdir $(o))),$(o)))
>
> This complicated filter returns entries from $(obj-y) that contain a
> slash, is that correct? If so, is it really necessary? Why not simply
> add whole $(obj-y) to $(obj-dirs) and be done? $(multi-objs) is also
> added without any filtering.
>
> > +obj-dirs := $(dir $(multi-objs) $(__subdir-obj-y))
Yes, You are right.
It is enough that just add $(obj-y) to $(obj-dirs) directly.
I will resend the patch.
--
Best Regards,
zzs
next prev parent reply other threads:[~2013-06-30 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1370335532-17891-1-git-send-email-zzs0213@gmail.com>
[not found] ` <1370335532-17891-2-git-send-email-zzs0213@gmail.com>
2013-06-28 22:44 ` [PATCH] let kbuild mkdir for dir/file.o Michal Marek
2013-06-30 8:01 ` 张忠山
2013-06-30 9:02 ` 张忠山 [this message]
2013-06-30 9:09 ` 张忠山
2013-07-03 20:49 ` Michal Marek
2013-07-04 1:35 ` 张忠山
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130630090203.GA6557@greatfirst.com \
--to=zzs0213@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox