From: Oleg Nesterov <oleg@redhat.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate
Date: Tue, 2 Jul 2013 22:01:47 +0200 [thread overview]
Message-ID: <20130702200147.GC9359@redhat.com> (raw)
In-Reply-To: <1372696755-17427-1-git-send-email-dvlasenk@redhat.com>
On 07/01, Denys Vlasenko wrote:
>
> Grepping for numeric constants is inconvenient.
Personally I agree very much, and I like the intent.
> +#define WTERMSIG_MASK 0x7f
> +#define WTERMSIG(status) ((status) & WTERMSIG_MASK)
> +#define WCOREDUMP(status) ((status) & 0x80)
But I am not sure we need WTERMSIG/WCOREDUMP helpers, although
I won't really argue.
OTOH, I think it would be nice to add the name for 0x80 and
change coredump_finish().
And if we do not add WTERMSIG(), then perhaps we can turn other
0x7f's into WTERMSIG_MASK?
Oleg.
next prev parent reply other threads:[~2013-07-02 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 16:39 [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate Denys Vlasenko
2013-07-02 20:01 ` Oleg Nesterov [this message]
2013-07-04 9:03 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702200147.GC9359@redhat.com \
--to=oleg@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox