From: Felipe Balbi <balbi@ti.com>
To: Luciano Coelho <coelho@ti.com>
Cc: <balbi@ti.com>, <linux-wireless@vger.kernel.org>,
<tony@atomide.com>, <nsekhar@ti.com>, <mturquette@linaro.org>,
<mark.rutland@arm.com>, <grant.likely@linaro.org>,
<rob.herring@calxeda.com>, <devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree
Date: Wed, 3 Jul 2013 00:32:08 +0300 [thread overview]
Message-ID: <20130702213208.GC10388@arwen.pp.htv.fi> (raw)
In-Reply-To: <1372796394.21065.89.camel@cumari.coelho.fi>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Tue, Jul 02, 2013 at 11:19:54PM +0300, Luciano Coelho wrote:
> On Tue, 2013-07-02 at 18:35 +0300, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote:
> > > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func,
> > > /* Use block mode for transferring over one block size of data */
> > > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE;
> > >
> > > + sdio_set_drvdata(func, glue);
> >
> > is this move really necessary ?
>
> It is, because I use the glue in wlcore_get_pdata_from_of(), so I need
> to call sdio_set_drvdata() earlier. I reckoned it wouldn't hurt to move
> this, so I wouldn't have to pass the glue in the
> wlcore_get_pdata_from_of() call.
that's alright, it does look like it deserves a mention in changelog
though. Other than that:
Reviewed-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-02 21:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 14:55 [PATCH v2 0/9] wilink: add device tree support Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 1/9] wl1251: split wl251 platform data to a separate structure Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 2/9] wlcore: use irq_flags in pdata instead of hiding it behind a quirk Luciano Coelho
2013-07-02 15:26 ` Felipe Balbi
2013-07-02 20:12 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 3/9] wlcore: remove pwr_in_suspend from platform data Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 4/9] wl12xx: use frequency instead of enumerations for pdata clocks Luciano Coelho
2013-07-02 15:02 ` Nishanth Menon
2013-07-02 20:27 ` Luciano Coelho
2013-07-03 11:33 ` Tony Lindgren
2013-07-03 12:14 ` Luciano Coelho
2013-07-02 15:31 ` Felipe Balbi
2013-07-02 20:14 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 5/9] wlcore: always use one-shot IRQ Luciano Coelho
2013-07-02 15:32 ` Felipe Balbi
2013-07-02 20:16 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 6/9] wlcore: add initial device tree support to the sdio module Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 7/9] wlcore: sdio: add wilink clock providers Luciano Coelho
2013-07-02 15:34 ` Felipe Balbi
2013-07-02 21:30 ` Felipe Balbi
2013-07-02 14:55 ` [PATCH v2 8/9] wlcore: sdio: get clocks from device tree Luciano Coelho
2013-07-02 15:35 ` Felipe Balbi
2013-07-02 20:19 ` Luciano Coelho
2013-07-02 21:32 ` Felipe Balbi [this message]
2013-07-02 21:38 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 9/9] wlcore/wl12xx: check if we got correct clock data from DT Luciano Coelho
2013-07-03 10:13 ` [PATCH v2 0/9] wilink: add device tree support Grazvydas Ignotas
2013-07-03 13:45 ` Luciano Coelho
2013-09-21 12:27 ` Pavel Machek
2013-09-21 14:16 ` Sebastian Reichel
2013-09-22 13:36 ` Pavel Machek
2013-09-22 14:24 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702213208.GC10388@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=coelho@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox