From: Mark Brown <broonie@kernel.org>
To: Yadwinder Singh Brar <yadi.brar01@gmail.com>
Cc: Yadwinder Singh Brar <yadi.brar@samsung.com>,
linux-kernel@vger.kernel.org, sbkim73@samsung.com,
Liam Girdwood <lgirdwood@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH 3/4] mfd: s2mps11: Add device tree support
Date: Thu, 4 Jul 2013 15:51:26 +0100 [thread overview]
Message-ID: <20130704145126.GB27646@sirena.org.uk> (raw)
In-Reply-To: <CAKew6eVWt==t3NZTwvULTBmWSHkAf6jNuPcj8p711st_7ZmRAw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Thu, Jul 04, 2013 at 05:13:46PM +0530, Yadwinder Singh Brar wrote:
> On Thu, Jul 4, 2013 at 2:52 PM, Mark Brown <broonie@kernel.org> wrote:
> > That's just an issue in the code if that is the case, you can test for
> > the presence of a property independently of getting its value.
> Yes, for that we will need an extra flag (ramp_disable) in
> constraints, to figure out whether
> ramp-rate is actually set to zero or its left (by default) zero if we
> do it in common code as
> now we have locally in driver.
Yes, I agree that makes sense for the constraints.
> I think its matter of assumption, so to conclude our discussion,
> please let me know that which approach we should use:
> - assume "regulator-ramp-delay = <0>" as ramp_disable.
> or
> - parsing "regulator_ramp_disable" from DT.
I prefer the first option.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-04 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 11:20 [PATCH 0/4] Add DT support for s2mps11 Yadwinder Singh Brar
2013-06-24 11:20 ` [PATCH 1/4] regulator: s2mps11: Convert ramp rate to uV/us and set default ramp rate Yadwinder Singh Brar
2013-07-03 17:51 ` Mark Brown
2013-06-24 11:20 ` [PATCH 2/4] regulator: s2mps11: Implement set_voltage_time_sel() ops for bucks Yadwinder Singh Brar
2013-07-03 11:55 ` Sachin Kamat
2013-07-03 12:31 ` Yadwinder Singh Brar
2013-07-03 17:55 ` Mark Brown
2013-06-24 11:20 ` [PATCH 3/4] mfd: s2mps11: Add device tree support Yadwinder Singh Brar
2013-07-03 11:46 ` Sachin Kamat
2013-07-03 18:05 ` Mark Brown
2013-07-04 5:07 ` Yadwinder Singh Brar
2013-07-04 9:22 ` Mark Brown
2013-07-04 11:43 ` Yadwinder Singh Brar
2013-07-04 14:51 ` Mark Brown [this message]
2013-06-24 11:20 ` [PATCH 4/4] regulator: " Yadwinder Singh Brar
2013-07-03 11:53 ` Sachin Kamat
2013-07-03 12:45 ` Yadwinder Singh Brar
2013-07-03 18:00 ` Mark Brown
2013-07-04 5:14 ` Yadwinder Singh Brar
2013-07-04 9:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704145126.GB27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
--cc=yadi.brar01@gmail.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox