From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alexandre.bounine@idt.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] rapidio: use after free in unregister function
Date: Fri, 5 Jul 2013 09:02:31 +0300 [thread overview]
Message-ID: <20130705060231.GA14443@elgon.mountain> (raw)
We need to use the _safe version of list_for_each_entry() because we
are freeing the iterator.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
index f4f30af..84ac64a 100644
--- a/drivers/rapidio/rio.c
+++ b/drivers/rapidio/rio.c
@@ -1701,7 +1701,7 @@ EXPORT_SYMBOL_GPL(rio_register_scan);
int rio_unregister_scan(int mport_id, struct rio_scan *scan_ops)
{
struct rio_mport *port;
- struct rio_scan_node *scan;
+ struct rio_scan_node *scan, *tmp;
pr_debug("RIO: %s for mport_id=%d\n", __func__, mport_id);
@@ -1715,7 +1715,7 @@ int rio_unregister_scan(int mport_id, struct rio_scan *scan_ops)
(mport_id == RIO_MPORT_ANY && port->nscan == scan_ops))
port->nscan = NULL;
- list_for_each_entry(scan, &rio_scans, node)
+ list_for_each_entry_safe(scan, tmp, &rio_scans, node)
if (scan->mport_id == mport_id) {
list_del(&scan->node);
kfree(scan);
next reply other threads:[~2013-07-05 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 6:02 Dan Carpenter [this message]
2013-07-05 7:06 ` [patch] rapidio: use after free in unregister function Ryan Mallon
2013-07-05 7:19 ` Dan Carpenter
2013-07-05 19:04 ` Bounine, Alexandre
2013-07-05 20:39 ` [patch v2] " Dan Carpenter
2013-07-05 23:26 ` Ryan Mallon
2013-07-08 11:55 ` Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705060231.GA14443@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=alexandre.bounine@idt.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox