* [PATCH, re-send] drm: always provide debugfs function prototypes
@ 2013-07-05 15:41 Arnd Bergmann
0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2013-07-05 15:41 UTC (permalink / raw)
To: Dave Airlie; +Cc: linux-kernel, linux-arm-kernel, Thierry Reding, dri-devel
It is generally considered bad style to enclose function prototypes
in header files in #ifdef. This case illustrates why that is:
The tegra host1x driver calls into the debugfs functions if
CONFIG_DEBUG_FS is enabled, but that code is otherwise already
discarded by the compiler, so leaving the prototype in place
actually makes everything work.
drivers/gpu/host1x/drm/dc.c: In function 'tegra_dc_debugfs_init':
drivers/gpu/host1x/drm/dc.c:1004:2: error: implicit declaration of function 'drm_debugfs_create_files' [-Werror=implicit-function-declaration]
drivers/gpu/host1x/drm/dc.c: In function 'tegra_dc_debugfs_exit': drivers/gpu/host1x/drm/dc.c:1026:2: error: implicit declaration of function 'drm_debugfs_remove_files' [-Werror=implicit-function-declaration]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Thierry Reding <thierry.reding@>
Cc: Ben Gamari <bgamari@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 63d17ee..8bc105e 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1551,7 +1551,7 @@ extern int drm_proc_init(struct drm_minor *minor, struct proc_dir_entry *root);
extern int drm_proc_cleanup(struct drm_minor *minor, struct proc_dir_entry *root);
/* Debugfs support */
-#if defined(CONFIG_DEBUG_FS)
+
extern int drm_debugfs_init(struct drm_minor *minor, int minor_id,
struct dentry *root);
extern int drm_debugfs_create_files(struct drm_info_list *files, int count,
@@ -1559,7 +1559,6 @@ extern int drm_debugfs_create_files(struct drm_info_list *files, int count,
extern int drm_debugfs_remove_files(struct drm_info_list *files, int count,
struct drm_minor *minor);
extern int drm_debugfs_cleanup(struct drm_minor *minor);
-#endif
/* Info file support */
extern int drm_name_info(struct seq_file *m, void *data);
diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
index 88591ef..4a7759a 100644
--- a/include/drm/drm_mm.h
+++ b/include/drm/drm_mm.h
@@ -37,9 +37,7 @@
* Generic range manager structs
*/
#include <linux/list.h>
-#ifdef CONFIG_DEBUG_FS
#include <linux/seq_file.h>
-#endif
struct drm_mm_node {
struct list_head node_list;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-07-05 15:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-05 15:41 [PATCH, re-send] drm: always provide debugfs function prototypes Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox