Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

Takashi Iwai
2013-07-09T15:12:00Z

At Tue, 9 Jul 2013 23:06:05 +0800,
Ming Lei wrote:
>
> On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > At Tue, 9 Jul 2013 22:39:36 +0800,
> > Ming Lei wrote:
> >>
> >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > At Tue, 9 Jul 2013 16:43:30 +0800,
> >> >> Actually from view of distribution, dell rbu has to be compiled in, then
> >> >> no code size can be saved any more, which means looks the introduced
> >> >> option in this patch isn't necessary.
> >> >
> >> > Well, but it means that there is no way not to compile user-helper
> >> > mode code in firmware_class.c. In other words, in which condition,
> >> > request_firmware_user() will be compiled?
> >>
> >> It can be always compiled in. Basically dell rbu is always enabled in
> >> distributions, which means the user helper code has to be compiled in.
> >
> > But how non-distro kernel disables this being built-in...?
> > Or do you suggest to enable the user-helper codes always built, no
> > matter whether it's used or not?
>
> The only cost of built-in user helper code is ~6Kbytes code on my armv7
> box.
>
> If the 6KB memory does mater for this non-distro kernel, we can introduce
> more options.

Well, if it doesn't matter, we don't need CONFIG_FW_LOADER_USER_HELPER
either. The goal of this option is to kill the user helper code, not
intended as a workaround for 60 seconds stall.

Takashi