From: Fengguang Wu <fengguang.wu@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
Jim Garlick <garlick@llnl.gov>,
Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible
Date: Mon, 8 Jul 2013 12:47:47 +0800 [thread overview]
Message-ID: <20130708044747.GA23911@localhost> (raw)
In-Reply-To: <20130708044542.GE20091@localhost>
> > > TRAILING_STATEMENTS
> >
> > False positives? Got an example?
>
> tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next
> head: d2989b534ef6834ebf2425aecc040b894b567c91
> commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy engine context stored in ramfc, not externally
>
> ERROR: trailing statements should be on next line
> #28: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:146:
> + case NVDEV_ENGINE_GR : addr = 0x0210; break;
>
> ERROR: trailing statements should be on next line
> #40: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:183:
> + case NVDEV_ENGINE_COPY2: addr = 0x0000; break;
>
> ERROR: trailing statements should be on next line
> #41: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:184:
> + case NVDEV_ENGINE_GR : addr = 0x0210; break;
In this case the code does look neat:
switch (nv_engidx(object->engine)) {
case NVDEV_ENGINE_SW : return 0;
- case NVDEV_ENGINE_GR :
case NVDEV_ENGINE_COPY0:
- case NVDEV_ENGINE_COPY1: addr = 0x0210; break;
+ case NVDEV_ENGINE_COPY1:
+ case NVDEV_ENGINE_COPY2: addr = 0x0000; break;
+ case NVDEV_ENGINE_GR : addr = 0x0210; break;
case NVDEV_ENGINE_BSP : addr = 0x0270; break;
case NVDEV_ENGINE_VP : addr = 0x0250; break;
case NVDEV_ENGINE_PPP : addr = 0x0260; break;
Thanks,
Fengguang
next prev parent reply other threads:[~2013-07-08 4:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51d9c6c4.k6qhnvy45dNR8Ghq%fengguang.wu@intel.com>
[not found] ` <20130708004233.GA8958@localhost>
[not found] ` <CAFkjPTk5EZ_d5BdTTHjgrwdtU1XfZ3go_7ZDCv4Q_oqnn95AHg@mail.gmail.com>
2013-07-08 3:30 ` [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible Fengguang Wu
2013-07-08 3:54 ` Joe Perches
2013-07-08 4:45 ` Fengguang Wu
2013-07-08 4:47 ` Fengguang Wu [this message]
2013-07-08 4:57 ` Fengguang Wu
2013-07-08 4:54 ` Joe Perches
2013-07-08 7:28 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708044747.GA23911@localhost \
--to=fengguang.wu@intel.com \
--cc=apw@canonical.com \
--cc=ericvh@gmail.com \
--cc=garlick@llnl.gov \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox