public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf tools: Fix boolean for NO_LIBPYTHON=1 NO_LIBPERL=1 build
@ 2013-07-07 13:55 Jiri Olsa
  2013-07-08 15:18 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Olsa @ 2013-07-07 13:55 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jiri Olsa, Waiman Long, Arnaldo Carvalho de Melo, Peter Zijlstra,
	Ingo Molnar, Paul Mackerras, Corey Ashford, Frederic Weisbecker,
	Namhyung Kim, David Ahern

The build is broken for 'NO_LIBPYTHON=1 NO_LIBPERL=1' switches.

The reason is that without perl and python support we
dont have TRUE/FALSE macro definitions in dso and vdso
objects (added there by commit 7821317).

Using stdbool.h defines instead which seems to be more
common in perf code anyway.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Waiman Long <Waiman.Long@hp.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
---
 tools/perf/util/dso.c  | 2 +-
 tools/perf/util/vdso.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 3d80f92..c4374f0 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -531,7 +531,7 @@ struct dso *dsos__find(struct list_head *head, const char *name, bool cmp_short)
 
 struct dso *__dsos__findnew(struct list_head *head, const char *name)
 {
-	struct dso *dso = dsos__find(head, name, FALSE);
+	struct dso *dso = dsos__find(head, name, false);
 
 	if (!dso) {
 		dso = dso__new(name);
diff --git a/tools/perf/util/vdso.c b/tools/perf/util/vdso.c
index a8fd73d..3915982 100644
--- a/tools/perf/util/vdso.c
+++ b/tools/perf/util/vdso.c
@@ -91,7 +91,7 @@ void vdso__exit(void)
 
 struct dso *vdso__dso_findnew(struct list_head *head)
 {
-	struct dso *dso = dsos__find(head, VDSO__MAP_NAME, TRUE);
+	struct dso *dso = dsos__find(head, VDSO__MAP_NAME, true);
 
 	if (!dso) {
 		char *file;
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] perf tools: Fix boolean for NO_LIBPYTHON=1 NO_LIBPERL=1 build
  2013-07-07 13:55 [PATCH] perf tools: Fix boolean for NO_LIBPYTHON=1 NO_LIBPERL=1 build Jiri Olsa
@ 2013-07-08 15:18 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-07-08 15:18 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: linux-kernel, Waiman Long, Peter Zijlstra, Ingo Molnar,
	Paul Mackerras, Corey Ashford, Frederic Weisbecker, Namhyung Kim,
	David Ahern

Em Sun, Jul 07, 2013 at 03:55:39PM +0200, Jiri Olsa escreveu:
> The build is broken for 'NO_LIBPYTHON=1 NO_LIBPERL=1' switches.
> 
> The reason is that without perl and python support we
> dont have TRUE/FALSE macro definitions in dso and vdso
> objects (added there by commit 7821317).
> 
> Using stdbool.h defines instead which seems to be more
> common in perf code anyway.

Thanks, applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-08 15:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-07 13:55 [PATCH] perf tools: Fix boolean for NO_LIBPYTHON=1 NO_LIBPERL=1 build Jiri Olsa
2013-07-08 15:18 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox