From: Mark Brown <broonie@kernel.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Sourav Poddar <sourav.poddar@ti.com>,
spi-devel-general@lists.sourceforge.net, grant.likely@linaro.org,
rnayak@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller
Date: Tue, 9 Jul 2013 11:05:26 +0100 [thread overview]
Message-ID: <20130709100525.GR27646@sirena.org.uk> (raw)
In-Reply-To: <20130709065143.GC5552@arwen.pp.htv.fi>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Tue, Jul 09, 2013 at 09:51:43AM +0300, Felipe Balbi wrote:
> > Looks like a case to use regmap?
> > Dumb q: why cant we use regmap_spi? worst case, you should be able to
> read regmap-spi and you'll see why it can't be used in this case.
> regmap-spi is for SPI clients who want to read their register map
> through SPI commands. This is a driver for the SPI master which has its
> registers memory mapped.
Indeed, regmap-spi would be a client of this driver. Though there is
regmap-mmio which may be helpful, on the other hand it's relatively
heavyweight and SPI can be a bit performance sensitive so perhaps it's
not awesome here. Russell did mention the idea of some helpers along a
similar style though, they may be a good idea but nobody wrote them yet.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-09 10:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:42 [PATCH 0/3] spi changes and ti quad spi controller Sourav Poddar
2013-07-08 13:42 ` [RFC/PATCH 1/3] driver: spi: Modify core to compute the message length Sourav Poddar
2013-07-08 15:02 ` Mark Brown
2013-07-08 13:42 ` [PATCHv3 2/3] drivers: spi: Add qspi flash controller Sourav Poddar
2013-07-08 14:32 ` Felipe Balbi
2013-07-09 7:29 ` Sourav Poddar
2013-07-11 9:12 ` Sourav Poddar
2013-07-08 20:33 ` Nishanth Menon
2013-07-09 6:51 ` Felipe Balbi
2013-07-09 10:05 ` Mark Brown [this message]
2013-07-09 12:32 ` Nishanth Menon
2013-07-09 12:50 ` Nishanth Menon
2013-07-09 14:40 ` Mark Brown
2013-07-09 14:53 ` Nishanth Menon
2013-07-09 7:20 ` Sourav Poddar
2013-07-08 13:43 ` [RFC/PATCH 3/3] driver: spi: Add quad spi read support Sourav Poddar
2013-07-08 14:36 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709100525.GR27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=balbi@ti.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=sourav.poddar@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox