From: Andrew Morton <akpm@linux-foundation.org>
To: Li Zefan <lizefan@huawei.com>
Cc: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Eric Dumazet <edumazet@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] relay: fix timer madness
Date: Tue, 9 Jul 2013 20:57:55 -0700 [thread overview]
Message-ID: <20130709205755.aca39829.akpm@linux-foundation.org> (raw)
In-Reply-To: <51DCD6F6.2080802@huawei.com>
On Wed, 10 Jul 2013 11:37:26 +0800 Li Zefan <lizefan@huawei.com> wrote:
> On 2013/7/10 10:18, zhangwei(Jovi) wrote:
> > When I'm using ktap script to tracing all event tracepoints by relay
> > transport, without this patch, the system will hang in few seconds.
> >
> > I found the original patch discussion in 2007.
> > http://marc.info/?l=linux-kernel&m=118544794717162&w=2
> > (In that mail thread, the patch didn't fix that problem, but it fix
> > the problem I encountered now)
> >
> > Changed from v1:
> > mod timer interval changed from jiffies+1 to HZ/10, as Ingo suggested.
> >
> > Original patch changelog from Ingo in 2007:
> >
> > Remove timer calls (!!!) from deep within the tracing infrastructure.
> > This was totally bogus code that can cause lockups and worse.
> > Poll the buffer every 2 jiffies for now.
> >
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> I don't think this patch should have Andrew's signed-off-by?
I guess not, unless it was taken from -mm, which would be odd, as I
have the old version.
v1 has been in my tree for a few months - Ingo requested some updates
but nothing happened and I have not checked whether v2 addresses his
requests.
next prev parent reply other threads:[~2013-07-10 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 2:18 [PATCH V2] relay: fix timer madness zhangwei(Jovi)
2013-07-10 3:37 ` Li Zefan
2013-07-10 3:57 ` Andrew Morton [this message]
2013-07-19 22:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709205755.aca39829.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=edumazet@google.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox