From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: J Keerthy <j-keerthy@ti.com>,
mturquette@linaro.org, sameo@linux.intel.com,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
lgirdwood@gmail.com, t-kristo@ti.com, wim@iguana.be,
gg@slimlogic.co.uk, Ian Lartey <ian@slimlogic.co.uk>
Subject: Re: [PATCH] mfd: DT bindings for the palmas family MFD
Date: Wed, 10 Jul 2013 11:27:24 +0100 [thread overview]
Message-ID: <20130710102724.GC24508@sirena.org.uk> (raw)
In-Reply-To: <20130603141851.GG3370@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]
On Mon, Jun 03, 2013 at 03:18:51PM +0100, Lee Jones wrote:
> On Mon, 03 Jun 2013, J Keerthy wrote:
> > + optional chip specific regulator fields :-
> > + ti,warm-reset - maintain voltage during warm reset(boolean)
> Pushing the boat out a bit here, but is it possible to reuse
> 'regulator-always-on' for this?
This sounds more like "don't reset over reboot" than "never change the
enable state".
> > + ti,roof-floor - control voltage selection by pin(boolean)
> Is this the same as a GPIO regulator?
> If so, you might not need to add superfluous vendor specific properties.
Lots of regulators have the ability to do things like switch between
programmable voltages based on GPIOs (enabling a fast change to a known
voltage) - the roof-floor naming sounds like this. Usually there's also
register based element for selecting the voltage.
> See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> > + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
> > + 2 - eco, 3 - forced pwm
> I've seen lots of sleep-mode properties, can't we define a generic
> one?
We should make some of this more standard (at least things like
voltages) but the whole concept of what sleep mode is is at best fuzzy.
You typically need different selections for suspend to RAM and suspend
to disk, plus often the suspend configuration is dynamic depending on
what the system is doing since suspend is just CPU suspend not system
suspend and there's also some changes that might happen depending on
which wake sources are currently available.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-07-10 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 12:08 [PATCH] mfd: DT bindings for the palmas family MFD J Keerthy
2013-06-03 14:18 ` Lee Jones
2013-06-03 20:38 ` Stephen Warren
2013-06-04 6:24 ` J, KEERTHY
2013-06-04 7:21 ` Lee Jones
2013-06-04 5:28 ` J, KEERTHY
2013-07-10 10:27 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710102724.GC24508@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox