public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/2] virtio tools: strip bad include-path from Makefile
Date: Wed, 10 Jul 2013 15:42:53 +0300	[thread overview]
Message-ID: <20130710124253.GA12645@redhat.com> (raw)
In-Reply-To: <CALkWK0k49QDWcupnhhgDh4WVP-xT1f2rvDkteChZyjWo48u9qw@mail.gmail.com>

On Wed, Jul 10, 2013 at 05:50:04PM +0530, Ramkumar Ramachandra wrote:
> Michael S. Tsirkin wrote:
> >> CFLAGS contains a mysterious "-I ../../usr/include", but no such path
> >> exists in the linux tree.  The line was originally introduced in
> >> 4e53f78e (tools/virtio: virtio_test tool, 2010-11-29), but no such path
> >> existed in the tree even then.
> >
> > It exists if you do make headers_install.
> 
> I see.  Why do we need these (or userspace headers) when /include
> exists in the linux tree though?

This is usespace code so it needs the cleaned-up version from
usr/include, not the internal kernel one.

> > So it's handy for old distos where userspace headers don't
> > exist or are out of date.
> 
> I thought userspace headers (linux-kernel-headers package in my
> distribution) are used for building kernel modules that exist as
> independent projects outside the linux tree (?).

userspace headers are for userspace, not for external modules.
I don't know what does your distro puts in a linux-kernel-headers
package.

-- 
MST

  reply	other threads:[~2013-07-10 12:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 10:56 [PATCH 0/2] virtio tools: build failure Ramkumar Ramachandra
2013-07-10 10:56 ` [PATCH 1/2] virtio tools: strip bad include-path from Makefile Ramkumar Ramachandra
2013-07-10 12:15   ` Michael S. Tsirkin
2013-07-10 12:20     ` Ramkumar Ramachandra
2013-07-10 12:42       ` Michael S. Tsirkin [this message]
2013-07-10 13:22         ` Ramkumar Ramachandra
2013-07-10 13:26           ` Michael S. Tsirkin
2013-07-10 10:57 ` [PATCH] virtio tools: add .gitignore Ramkumar Ramachandra
2013-07-10 12:16   ` Michael S. Tsirkin
2013-07-11  2:54     ` Rusty Russell
2013-07-10 12:18 ` [PATCH 0/2] virtio tools: build failure Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130710124253.GA12645@redhat.com \
    --to=mst@redhat.com \
    --cc=artagnon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox