Re: [PATCH 2/6] sysfs.h: add ATTRIBUTE_GROUPS() macro

Re: [PATCH 2/6] sysfs.h: add ATTRIBUTE_GROUPS() macro

[Guenter Roeck]

On Wed, Jul 10, 2013 at 01:05:10PM -0700, Greg Kroah-Hartman wrote:
> To make it easier for driver subsystems to work with attribute groups,
> create the ATTRIBUTE_GROUPS macro to remove some of the repetitive
> typing for the most common use for attribute groups.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  include/linux/sysfs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index 9cd20c8..f62ff01 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -94,6 +94,15 @@ struct attribute_group {
>  #define __ATTR_IGNORE_LOCKDEP	__ATTR
>  #endif
>  
> +#define ATTRIBUTE_GROUPS(name)					\

Would it be possible to add is_visible as additional argument ?

Thanks,
Guenter

> +static const struct attribute_group name##_group = {		\
> +	.attrs = name##_attrs,					\
> +};								\
> +static const struct attribute_group *name##_groups[] = {	\
> +	&name##_group,						\
> +	NULL,							\
> +}
> +
>  #define attr_name(_attr) (_attr).attr.name
>  
>  struct file;
> -- 
> 1.8.3.rc0.20.gb99dd2e
> 
> 

Re: [PATCH 2/6] sysfs.h: add ATTRIBUTE_GROUPS() macro

[Greg Kroah-Hartman]

On Wed, Jul 10, 2013 at 03:48:56PM -0700, Guenter Roeck wrote:
> On Wed, Jul 10, 2013 at 01:05:10PM -0700, Greg Kroah-Hartman wrote:
> > To make it easier for driver subsystems to work with attribute groups,
> > create the ATTRIBUTE_GROUPS macro to remove some of the repetitive
> > typing for the most common use for attribute groups.
> > 
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  include/linux/sysfs.h | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> > index 9cd20c8..f62ff01 100644
> > --- a/include/linux/sysfs.h
> > +++ b/include/linux/sysfs.h
> > @@ -94,6 +94,15 @@ struct attribute_group {
> >  #define __ATTR_IGNORE_LOCKDEP	__ATTR
> >  #endif
> >  
> > +#define ATTRIBUTE_GROUPS(name)					\
> 
> Would it be possible to add is_visible as additional argument ?

I thought about the other options (multiple groups, is_visible, and
bin_attrs), but those are almost all not the "normal" usage, so I figure
it's worth the extra 6 lines of text if you want to support is_visible
or binary attributes.

After converting all of the class code to use groups, it seems to match
up with the defaults, but if in the future it's more popular than
expected, I'll gladly add it.

thanks,

greg k-h

Re: [PATCH 2/6] sysfs.h: add ATTRIBUTE_GROUPS() macro

[Guenter Roeck]

On Wed, Jul 10, 2013 at 03:57:30PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jul 10, 2013 at 03:48:56PM -0700, Guenter Roeck wrote:
> > On Wed, Jul 10, 2013 at 01:05:10PM -0700, Greg Kroah-Hartman wrote:
> > > To make it easier for driver subsystems to work with attribute groups,
> > > create the ATTRIBUTE_GROUPS macro to remove some of the repetitive
> > > typing for the most common use for attribute groups.
> > > 
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > >  include/linux/sysfs.h | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> > > index 9cd20c8..f62ff01 100644
> > > --- a/include/linux/sysfs.h
> > > +++ b/include/linux/sysfs.h
> > > @@ -94,6 +94,15 @@ struct attribute_group {
> > >  #define __ATTR_IGNORE_LOCKDEP	__ATTR
> > >  #endif
> > >  
> > > +#define ATTRIBUTE_GROUPS(name)					\
> > 
> > Would it be possible to add is_visible as additional argument ?
> 
> I thought about the other options (multiple groups, is_visible, and
> bin_attrs), but those are almost all not the "normal" usage, so I figure
> it's worth the extra 6 lines of text if you want to support is_visible
> or binary attributes.
> 
Ok, fair enough.

Thanks,
Guenter

Driver core and sysfs changes for attribute groups

[Greg Kroah-Hartman]

Hi all,

Guenter and Oliver have been pointing out a few limitations of the
driver core's ability to create files properly (i.e. in a way that
doesn't race with userspace.)  The driver core allows this, but it
doesn't export that ability to drivers very easily, and for binary
files, not at all.

So here's a set of 6 patches that I'll be queueing up to go to Linus in
time for 3.11 so that people can start using them in their driver
subsystems.  It adds some new macros to make using attributes and
attribute groups easier, adds binary file capabilities to attribute
groups, and finally, lets subsystems (like platform drivers) set a
attribute group for when their device is created.

If anyone has any problems with these patches, please let me know.

Guenter, I've tweaked your original patch a bit, changing the name of
the function and putting the kernel doc comments in the correct place so
the build doesn't complain about it.

I also have a set of follow-on patches, about 50+ big so far, that goes
through the kernel and converts different drivers and subsystems to
properly use attribute groups, instead of open-coding binary files and
attributes.  Those patches will be sent out later, and will be for 3.12
as they aren't needed at the moment, this infrastructure changes are
needed first.

thanks,

greg k-h

[PATCH 2/6] sysfs.h: add ATTRIBUTE_GROUPS() macro

[Greg Kroah-Hartman]

To make it easier for driver subsystems to work with attribute groups,
create the ATTRIBUTE_GROUPS macro to remove some of the repetitive
typing for the most common use for attribute groups.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 include/linux/sysfs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 9cd20c8..f62ff01 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -94,6 +94,15 @@ struct attribute_group {
 #define __ATTR_IGNORE_LOCKDEP	__ATTR
 #endif
 
+#define ATTRIBUTE_GROUPS(name)					\
+static const struct attribute_group name##_group = {		\
+	.attrs = name##_attrs,					\
+};								\
+static const struct attribute_group *name##_groups[] = {	\
+	&name##_group,						\
+	NULL,							\
+}
+
 #define attr_name(_attr) (_attr).attr.name
 
 struct file;
-- 
1.8.3.rc0.20.gb99dd2e