public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: tpmdd-devel@lists.sourceforge.net
Cc: Shuah Khan <shuah.kh@samsung.com>,
	rafael.j.wysocki@intel.com, bhelgaas@google.com,
	a.zummo@towertech.it, key@linux.vnet.ibm.com, mail@srajiv.net,
	tpmdd@selhorst.net, tpmdd@sirrix.com, matthew.garrett@nebula.com,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, shuahkhan@gmail.com
Subject: Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops
Date: Thu, 11 Jul 2013 00:51:04 +0200	[thread overview]
Message-ID: <201307110051.04726.PeterHuewe@gmx.de> (raw)
In-Reply-To: <1373429409-3944-1-git-send-email-shuah.kh@samsung.com>

Hi,

thanks for your patch
>  static struct pnp_device_id tpm_pnp_tbl[] = {
>  	{"PNP0C31", 0},		/* TPM */
>  	{"ATM1200", 0},		/* Atmel */
> @@ -835,9 +834,12 @@ static struct pnp_driver tis_pnp_driver = {
>  	.name = "tpm_tis",
>  	.id_table = tpm_pnp_tbl,
>  	.probe = tpm_tis_pnp_init,
> -	.suspend = tpm_tis_pnp_suspend,
> -	.resume = tpm_tis_pnp_resume,
>  	.remove = tpm_tis_pnp_remove,
> +#ifdef CONFIG_PM_SLEEP
> +	.driver	= {
> +		.pm = &tpm_tis_pm,
> +	},
> +#endif
>  };


I don't think the #if CONFIG_PM_SLEEP is required here.

Thanks,
Peter

  reply	other threads:[~2013-07-10 22:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10  4:10 [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops Shuah Khan
2013-07-10 22:51 ` Peter Hüwe [this message]
2013-07-10 23:02   ` [tpmdd-devel] " Shuah Khan
2013-07-10 23:37     ` Peter Hüwe
2013-07-11  1:30       ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201307110051.04726.PeterHuewe@gmx.de \
    --to=peterhuewe@gmx.de \
    --cc=a.zummo@towertech.it \
    --cc=bhelgaas@google.com \
    --cc=key@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@srajiv.net \
    --cc=matthew.garrett@nebula.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=shuah.kh@samsung.com \
    --cc=shuahkhan@gmail.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    --cc=tpmdd@sirrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox