From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT] irqchip: sun4i: Remove wrong irq_ack callback implementation
Date: Thu, 11 Jul 2013 18:13:53 +0200 [thread overview]
Message-ID: <20130711161353.GV11243@lukather> (raw)
In-Reply-To: <1373121329.13289.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
Hi Axel,
On Sat, Jul 06, 2013 at 10:35:29PM +0800, Axel Lin wrote:
> According to the datasheet[1], the Interrupt IRQ Pending Registers are
> read-only. The implementation of sun4i_irq_ack() looks wrong because it writes
> to these read-only registers.
Right, but the datasheet also says that these registers are "clear"
register, which might indicate that it's actually R/W.
I actually used one of the code dump from Allwinner for this driver, so
I'm not exactly sure about wether irq_ack is needed or not.
I'll test this and let you know.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-11 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 14:35 [PATCH RFT] irqchip: sun4i: Remove wrong irq_ack callback implementation Axel Lin
2013-07-11 16:13 ` Maxime Ripard [this message]
2013-07-19 9:29 ` Geert Uytterhoeven
2013-07-24 9:51 ` Maxime Ripard
2013-07-19 8:20 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711161353.GV11243@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox