[PATCH] staging/lustre/libcfs: fix typo "default false"

[PATCH] staging/lustre/libcfs: fix typo "default false"

[Paul Bolle]

Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested lightly, with "make menuconfig" only.

1) No-one noticed because "default <invalid Kconfig symbol>" and
"default n" behave the same. Actually, it seems "default n" isn't needed
at all. But there are hundreds of Kconfig symbols that use "default n",
so I suppose it serves some purpose.

 drivers/staging/lustre/lustre/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index e0eb830..002dd2e 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -43,7 +43,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
 config LUSTRE_DEBUG_EXPENSIVE_CHECK
 	bool "Enable Lustre DEBUG checks"
 	depends on LUSTRE_FS
-	default false
+	default n
 	help
 	  This option is mainly for debug purpose. It enables Lustre code to do
 	  expensive checks that may have a performance impact.
-- 
1.8.1.4

Re: [PATCH] staging/lustre/libcfs: fix typo "default false"

[Greg Kroah-Hartman]

On Sat, Jul 13, 2013 at 04:40:46PM +0200, Paul Bolle wrote:
> Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
> "default false" to this Kconfig file. It was obviously meant to use
> "default n" here.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested lightly, with "make menuconfig" only.
> 
> 1) No-one noticed because "default <invalid Kconfig symbol>" and
> "default n" behave the same. Actually, it seems "default n" isn't needed
> at all. But there are hundreds of Kconfig symbols that use "default n",
> so I suppose it serves some purpose.
> 
>  drivers/staging/lustre/lustre/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index e0eb830..002dd2e 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -43,7 +43,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
>  config LUSTRE_DEBUG_EXPENSIVE_CHECK
>  	bool "Enable Lustre DEBUG checks"
>  	depends on LUSTRE_FS
> -	default false
> +	default n

Just remove it entirely, as you say, the default is 'n', so let's just
stick with that.

Care to redo this?

thanks,

greg k-h

[PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default

[Paul Bolle]

Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here. But we might as well drop this line, as a Kconfig bool
defaults to 'n' anyway.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v2: remove the default entirely, as Greg suggested.

1) Still tested with "make menuconfig" only. 

 drivers/staging/lustre/lustre/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index e0eb830..173d21e 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -43,7 +43,6 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
 config LUSTRE_DEBUG_EXPENSIVE_CHECK
 	bool "Enable Lustre DEBUG checks"
 	depends on LUSTRE_FS
-	default false
 	help
 	  This option is mainly for debug purpose. It enables Lustre code to do
 	  expensive checks that may have a performance impact.
-- 
1.8.1.4

Re: [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default

[Paul Bolle]

Greg,

I'm afraid I botched the Subject line. Please remove one instance of
"staging/lustre/libcfs:" from the summary.


Paul Bolle

Re: [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default

[Greg Kroah-Hartman]

On Sat, Jul 13, 2013 at 06:47:37PM +0200, Paul Bolle wrote:
> Greg,
> 
> I'm afraid I botched the Subject line. Please remove one instance of
> "staging/lustre/libcfs:" from the summary.

Please resend it.  When dealing with almost a thousand patches a kernel
release, editing subject lines by hand is not something I really like to
do.

thanks,

greg k-h

[PATCH v3] staging/lustre/libcfs: drop bogus Kconfig default

[Paul Bolle]

Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here. But we might as well drop this line, as a Kconfig bool
defaults to 'n' anyway.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v2: remove the default entirely, as Greg suggested.
   v3: Fix the botched summary.

1) Still lightly tested.

 drivers/staging/lustre/lustre/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index e0eb830..173d21e 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -43,7 +43,6 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
 config LUSTRE_DEBUG_EXPENSIVE_CHECK
 	bool "Enable Lustre DEBUG checks"
 	depends on LUSTRE_FS
-	default false
 	help
 	  This option is mainly for debug purpose. It enables Lustre code to do
 	  expensive checks that may have a performance impact.
-- 
1.8.1.4