* [PATCH] staging/lustre/libcfs: fix typo "default false"
@ 2013-07-13 14:40 Paul Bolle
2013-07-13 16:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-07-13 14:40 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested lightly, with "make menuconfig" only.
1) No-one noticed because "default <invalid Kconfig symbol>" and
"default n" behave the same. Actually, it seems "default n" isn't needed
at all. But there are hundreds of Kconfig symbols that use "default n",
so I suppose it serves some purpose.
drivers/staging/lustre/lustre/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index e0eb830..002dd2e 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -43,7 +43,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
config LUSTRE_DEBUG_EXPENSIVE_CHECK
bool "Enable Lustre DEBUG checks"
depends on LUSTRE_FS
- default false
+ default n
help
This option is mainly for debug purpose. It enables Lustre code to do
expensive checks that may have a performance impact.
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging/lustre/libcfs: fix typo "default false"
2013-07-13 14:40 [PATCH] staging/lustre/libcfs: fix typo "default false" Paul Bolle
@ 2013-07-13 16:07 ` Greg Kroah-Hartman
2013-07-13 16:44 ` [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default Paul Bolle
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-13 16:07 UTC (permalink / raw)
To: Paul Bolle; +Cc: devel, linux-kernel
On Sat, Jul 13, 2013 at 04:40:46PM +0200, Paul Bolle wrote:
> Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
> "default false" to this Kconfig file. It was obviously meant to use
> "default n" here.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested lightly, with "make menuconfig" only.
>
> 1) No-one noticed because "default <invalid Kconfig symbol>" and
> "default n" behave the same. Actually, it seems "default n" isn't needed
> at all. But there are hundreds of Kconfig symbols that use "default n",
> so I suppose it serves some purpose.
>
> drivers/staging/lustre/lustre/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index e0eb830..002dd2e 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -43,7 +43,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
> config LUSTRE_DEBUG_EXPENSIVE_CHECK
> bool "Enable Lustre DEBUG checks"
> depends on LUSTRE_FS
> - default false
> + default n
Just remove it entirely, as you say, the default is 'n', so let's just
stick with that.
Care to redo this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default
2013-07-13 16:07 ` Greg Kroah-Hartman
@ 2013-07-13 16:44 ` Paul Bolle
2013-07-13 16:47 ` Paul Bolle
0 siblings, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-07-13 16:44 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here. But we might as well drop this line, as a Kconfig bool
defaults to 'n' anyway.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v2: remove the default entirely, as Greg suggested.
1) Still tested with "make menuconfig" only.
drivers/staging/lustre/lustre/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index e0eb830..173d21e 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -43,7 +43,6 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
config LUSTRE_DEBUG_EXPENSIVE_CHECK
bool "Enable Lustre DEBUG checks"
depends on LUSTRE_FS
- default false
help
This option is mainly for debug purpose. It enables Lustre code to do
expensive checks that may have a performance impact.
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default
2013-07-13 16:44 ` [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default Paul Bolle
@ 2013-07-13 16:47 ` Paul Bolle
2013-07-13 17:26 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-07-13 16:47 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel
Greg,
I'm afraid I botched the Subject line. Please remove one instance of
"staging/lustre/libcfs:" from the summary.
Paul Bolle
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default
2013-07-13 16:47 ` Paul Bolle
@ 2013-07-13 17:26 ` Greg Kroah-Hartman
2013-07-13 18:46 ` [PATCH v3] " Paul Bolle
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-13 17:26 UTC (permalink / raw)
To: Paul Bolle; +Cc: devel, linux-kernel
On Sat, Jul 13, 2013 at 06:47:37PM +0200, Paul Bolle wrote:
> Greg,
>
> I'm afraid I botched the Subject line. Please remove one instance of
> "staging/lustre/libcfs:" from the summary.
Please resend it. When dealing with almost a thousand patches a kernel
release, editing subject lines by hand is not something I really like to
do.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] staging/lustre/libcfs: drop bogus Kconfig default
2013-07-13 17:26 ` Greg Kroah-Hartman
@ 2013-07-13 18:46 ` Paul Bolle
0 siblings, 0 replies; 6+ messages in thread
From: Paul Bolle @ 2013-07-13 18:46 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here. But we might as well drop this line, as a Kconfig bool
defaults to 'n' anyway.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v2: remove the default entirely, as Greg suggested.
v3: Fix the botched summary.
1) Still lightly tested.
drivers/staging/lustre/lustre/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index e0eb830..173d21e 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -43,7 +43,6 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
config LUSTRE_DEBUG_EXPENSIVE_CHECK
bool "Enable Lustre DEBUG checks"
depends on LUSTRE_FS
- default false
help
This option is mainly for debug purpose. It enables Lustre code to do
expensive checks that may have a performance impact.
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-13 18:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-13 14:40 [PATCH] staging/lustre/libcfs: fix typo "default false" Paul Bolle
2013-07-13 16:07 ` Greg Kroah-Hartman
2013-07-13 16:44 ` [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default Paul Bolle
2013-07-13 16:47 ` Paul Bolle
2013-07-13 17:26 ` Greg Kroah-Hartman
2013-07-13 18:46 ` [PATCH v3] " Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox