From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Colin Cross <ccross@android.com>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] simple mmap() cleanups
Date: Sun, 14 Jul 2013 18:54:32 +0200 [thread overview]
Message-ID: <20130714165432.GA20828@redhat.com> (raw)
Hello.
Hopefully the simple cleanups, but need the authoritative acks.
I simply can't understand the VM_GROWS* check in mmap_region(),
did I miss something subtle? I will appreciate any review.
Can't resist. "(prot&PROT_WRITE) && !(file->f_mode&FMODE_WRITE)"
asks for the whitespace cleanup, but this will break the 80-col
rule. Perhaps we should relax it...
Oleg.
mm/mmap.c | 28 ++++++++++------------------
1 files changed, 10 insertions(+), 18 deletions(-)
next reply other threads:[~2013-07-14 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 16:54 Oleg Nesterov [this message]
2013-07-14 16:54 ` [PATCH 1/3] mm: shift VM_GROWS* check from mmap_region() to do_mmap_pgoff() Oleg Nesterov
2013-07-16 21:43 ` Andrew Morton
2013-07-20 2:02 ` Hugh Dickins
2013-07-20 15:22 ` [PATCH v2 0/1] " Oleg Nesterov
2013-07-20 15:23 ` [PATCH v2 1/1] " Oleg Nesterov
2013-07-22 23:30 ` Hugh Dickins
2013-07-14 16:54 ` [PATCH 2/3] mm: do_mmap_pgoff: cleanup the usage of file_inode() Oleg Nesterov
2013-07-14 16:54 ` [PATCH 3/3] mm: mmap_region: kill correct_wcount/inode, use allow_write_access() Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130714165432.GA20828@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).