From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-kernel@vger.kernel.org, abbotti@mev.co.uk,
oliver@schinagl.nl, linux@roeck-us.net
Subject: Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups
Date: Sun, 14 Jul 2013 17:32:32 -0700 [thread overview]
Message-ID: <20130715003232.GA25173@kroah.com> (raw)
In-Reply-To: <20130715102700.33e848c5dba966d49e530bda@canb.auug.org.au>
On Mon, Jul 15, 2013 at 10:27:00AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Sun, 14 Jul 2013 16:05:50 -0700 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > Anyone else have a better name for this macro:
> > #define DEVICE_PATTR(_name) &dev_attr_##_name.attr
> > that they can think of? It will cut down on the typing done for
> > attribute lists.
>
> Just one small peeve I have about all these places we do symbol pasting,
> is that it makes it impossible to find some things because grep complete
> fails us. We type them once (often by cutting and pasting), but try to
> find them who knows how many times?
>
> Just saying ...
Yeah, I know. But realize that the dev_attr_##_name variable was
originally created with a:
DEV_ATTR_RO(sysfs_file_name);
macro in the first place, so even trying to grep for dev_attr* brings up
nothing. At least this way the grep would find the same thing, so it
does make a little bit sense in a way, right?
Or am I just trying to justify it as I'm tired of typing all that...
greg k-h
next prev parent reply other threads:[~2013-07-15 0:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 23:05 [PATCH v3 01/10] Driver core and sysfs changes for attribute groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 01/10] sysfs.h: add __ATTR_RW() macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 02/10] sysfs.h: add ATTRIBUTE_GROUPS() macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 03/10] sysfs.h: add BIN_ATTR macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 04/10] driver core: device.h: add RW and RO attribute macros Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 05/10] sysfs: add support for binary attributes in groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 06/10] sysfs: prevent warning when only using binary attributes Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 07/10] driver core: Introduce device_create_groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 08/10] driver core: add default groups to struct class Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 09/10] sysfs: add more helper macro's for (bin_)attribute(_groups) Greg Kroah-Hartman
2013-07-14 23:06 ` [PATCH 10/10] sysfs: use file mode defines from stat.h Greg Kroah-Hartman
2013-07-15 0:27 ` [PATCH v3 01/10] Driver core and sysfs changes for attribute groups Stephen Rothwell
2013-07-15 0:32 ` Greg Kroah-Hartman [this message]
2013-07-15 9:41 ` Ian Abbott
2013-07-15 9:56 ` Ian Abbott
2013-07-18 23:54 ` Guenter Roeck
2013-07-19 0:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715003232.GA25173@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oliver@schinagl.nl \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox