public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	rostedt@goodmis.org
Subject: Re: nohz: Warn if the machine can not perform nohz_full
Date: Tue, 16 Jul 2013 03:03:46 +0200	[thread overview]
Message-ID: <20130716010344.GC13562@somewhere> (raw)
In-Reply-To: <20130715173848.GA1066@redhat.com>

On Mon, Jul 15, 2013 at 01:38:48PM -0400, Dave Jones wrote:
> On Mon, Jul 15, 2013 at 01:24:23PM -0400, Dave Jones wrote:
>  > On Mon, Jul 15, 2013 at 07:18:02PM +0200, Frederic Weisbecker wrote:
>  >  
>  >  > > So I guess you guys never want this to be enabled on distro kernels ?
>  >  > > If that's the case, can you add something to that effect in Kconfig ?
>  >  > 
>  >  > I believe we want it to be enabled on distros in the long term. But right now it would
>  >  > be a bad idea until the off case (nohz_full= parameter empty) is carefully optimized.
>  >  > I'm currently working on that.
>  >  > 
>  >  > Now for the unstable tsc, which is what it's about on the above code block, we need
>  >  > the tick to be there to leverage the sched clock madness. May be there could be some
>  >  > other solution that could work along full dynticks but for now we chose the easy path.
>  >  > 
>  >  > Are broken TSCs that common?
>  >  
>  > I just hit one apparently.  http://paste.fedoraproject.org/25421/73907845/raw/
>  > That's a fairly recent Atom board, so I suspect it's not uncommon on that platform.
> 
> And here's a Core Duo from circa 2008.
> http://paste.fedoraproject.org/25429/13739098/raw
> 
> Two for two so far. I get the feeling you guys are going to get a ton of these reports.

Definetly, so it comforts me on the fact we need to remove the warning, which may be
interpreted as the symptom of a bug to report while it's not.

We need to warn the user but through another way.

  parent reply	other threads:[~2013-07-16  1:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 17:08 nohz: Warn if the machine can not perform nohz_full Dave Jones
2013-07-15 17:18 ` Frederic Weisbecker
2013-07-15 17:24   ` Dave Jones
2013-07-15 17:38     ` Dave Jones
2013-07-15 18:49       ` Steven Rostedt
2013-07-15 18:56         ` Dave Jones
2013-07-15 19:30           ` Steven Rostedt
2013-07-16  1:10             ` Frederic Weisbecker
2013-07-16  1:05         ` Frederic Weisbecker
2013-07-16 14:22           ` [PATCH] nohz: Do not warn about unstable tsc unless user uses nohz_full Steven Rostedt
2013-07-16 16:12             ` Frederic Weisbecker
2013-07-16  1:03       ` Frederic Weisbecker [this message]
2013-07-16  1:01     ` nohz: Warn if the machine can not perform nohz_full Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130716010344.GC13562@somewhere \
    --to=fweisbec@gmail.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox