From: Andi Kleen <ak@linux.jf.intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.jf.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@infradead.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.jf.intel.com>,
h.mitake@gmail.com, kirill.shutemov@linux.jf.intel.com
Subject: Re: [PATCH] perf, tools, bench: Fix memcpy benchmark for large sizes
Date: Tue, 16 Jul 2013 07:20:10 -0700 [thread overview]
Message-ID: <20130716142010.GR5643@tassilo.jf.intel.com> (raw)
In-Reply-To: <20130716101100.C2A70E0090@blue.fi.intel.com>
> > @@ -117,6 +117,8 @@ static void alloc_mem(void **dst, void **src, size_t length)
> > *src = zalloc(length);
> > if (!src)
> > die("memory allocation failed - maybe length is too large?\n");
> > + /* Make sure to always replace the zero pages even if MMAP_THRESH is crossed */
> > + memset(src, 0, length);
>
> It should be memset(*src, 0, length) instead.
Thanks for catching. I wonder why it fixed the problem for me.
> There's fix for wrong memory allocation fail check in v3.11-rc1.
Doubt it matters.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
prev parent reply other threads:[~2013-07-16 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373675551-18684-1-git-send-email-andi@firstfloor.org>
2013-07-15 8:15 ` [PATCH] perf, tools, bench: Fix memcpy benchmark for large sizes Kirill A. Shutemov
2013-07-15 12:16 ` Hitoshi Mitake
2013-07-16 10:11 ` Kirill A. Shutemov
2013-07-16 13:14 ` Hitoshi Mitake
2013-07-16 14:20 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716142010.GR5643@tassilo.jf.intel.com \
--to=ak@linux.jf.intel.com \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=h.mitake@gmail.com \
--cc=kirill.shutemov@linux.jf.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox