From: Robert Richter <rric@kernel.org>
To: Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, jolsa@redhat.com,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org,
Borislav Petkov <bp@alien8.de>
Subject: [PATCH] perf tools: Fix 'make tools/perf'
Date: Tue, 16 Jul 2013 16:50:36 +0200 [thread overview]
Message-ID: <20130716145036.GH8731@rric.localhost> (raw)
In-Reply-To: <20130712093909.GD8731@rric.localhost>
On 12.07.13 10:39:09, Robert Richter wrote:
> On 12.07.13 01:49:40, tip-bot for Robert Richter wrote:
> > Commit-ID: 107de3724eff5a6fa6474a4d2aa5460b63749ebf
> > Gitweb: http://git.kernel.org/tip/107de3724eff5a6fa6474a4d2aa5460b63749ebf
> > Author: Robert Richter <robert.richter@linaro.org>
> > AuthorDate: Tue, 11 Jun 2013 17:22:38 +0200
> > Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
> > CommitDate: Mon, 8 Jul 2013 17:34:00 -0300
> >
> > perf tools: Fix build errors with O and DESTDIR make vars set
> $ make tools/perf
> LINK /home/robert/cx/linux/tools/perf/perf
> gcc: error: ../linux/tools/lib/lk/liblk.a: No such file or directory
Fix below.
-Robert
>From ff89180092114191b1871eaa2b6f18d17124b21e Mon Sep 17 00:00:00 2001
From: Robert Richter <robert.richter@linaro.org>
Date: Tue, 16 Jul 2013 15:46:27 +0200
Subject: [PATCH] perf tools: Fix 'make tools/perf'
Boris just raised another variant of building perf tools which is
broken:
$ make tools/perf
...
LINK /home/robert/cx/linux/tools/perf/perf
gcc: error: ../linux/tools/lib/lk/liblk.a: No such file or directory
The variant wasn't considered by:
107de37 perf tools: Fix build errors with O and DESTDIR make vars set
There are other variant of building perf too:
$ make -C tools perf
$ make -C tools/perf
Plus variants with O= and DESTDIR set.
This patch fixes the above and was tested with the following:
$ make O=... DESTDIR=... tools/perf
$ make O=... DESTDIR=... -C tools/ perf
$ make O=... DESTDIR=... -C tools/perf
$ make tools/perf
$ make -C tools/ perf
$ make -C tools/perf
Reported-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Robert Richter <robert.richter@linaro.org>
Signed-off-by: Robert Richter <rric@kernel.org>
---
tools/perf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 641fccd..1d718a9 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -124,7 +124,7 @@ strip-libs = $(filter-out -l%,$(1))
ifneq ($(OUTPUT),)
TE_PATH=$(OUTPUT)
ifneq ($(subdir),)
- LK_PATH=$(objtree)/lib/lk/
+ LK_PATH=$(OUTPUT)/../lib/lk/
else
LK_PATH=$(OUTPUT)
endif
--
1.8.3.2
next prev parent reply other threads:[~2013-07-16 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 15:22 [PATCH] perf tools: Fix build errors with O and DESTDIR make vars set Robert Richter
2013-07-12 8:49 ` [tip:perf/urgent] " tip-bot for Robert Richter
2013-07-12 9:39 ` Robert Richter
2013-07-16 14:50 ` Robert Richter [this message]
2013-07-17 15:31 ` [PATCH] perf tools: Fix 'make tools/perf' Arnaldo Carvalho de Melo
2013-07-17 15:40 ` Borislav Petkov
2013-07-17 16:10 ` Robert Richter
2013-07-18 12:19 ` Robert Richter
2013-07-18 16:19 ` Arnaldo Carvalho de Melo
2013-07-18 16:47 ` Robert Richter
2013-07-18 16:41 ` [PATCH] perf tools: Build docs with 'make all' Robert Richter
2013-07-19 7:53 ` [tip:perf/core] perf tools: Fix 'make tools/perf' tip-bot for Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716145036.GH8731@rric.localhost \
--to=rric@kernel.org \
--cc=acme@infradead.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox