From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932738Ab3GPPqV (ORCPT ); Tue, 16 Jul 2013 11:46:21 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:36691 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932590Ab3GPPqT (ORCPT ); Tue, 16 Jul 2013 11:46:19 -0400 Date: Tue, 16 Jul 2013 17:46:16 +0200 From: "'Maxime Ripard'" To: Jingoo Han Cc: "'Andrew Morton'" , "'Alexandre Belloni'" , hector.palacios@digi.com, "'Thomas Petazzoni'" , plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support Message-ID: <20130716154616.GK3125@lukather> References: <1373902022-20439-1-git-send-email-maxime.ripard@free-electrons.com> <1373902022-20439-4-git-send-email-maxime.ripard@free-electrons.com> <003601ce81c8$c2573320$47059960$@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3MHXEHrrXKLGx71o" Content-Disposition: inline In-Reply-To: <003601ce81c8$c2573320$47059960$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3MHXEHrrXKLGx71o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jingoo, On Tue, Jul 16, 2013 at 11:04:09AM +0900, Jingoo Han wrote: > On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote: > >=20 > > From: Alexandre Belloni > >=20 > > Add support for the Himax HX8369 controller as it is quite similar to t= he > > hx8357. > >=20 > > Signed-off-by: Alexandre Belloni > > Signed-off-by: Maxime Ripard >=20 > Hi Maxime Ripard, >=20 > I reviewed this patch with Himax HX8369 datasheet. > I cannot find any problems. It looks good. >=20 > However, if possible, please add comment on huge delays such as > msleep(120), msleep(100), etc. Right. I'll send a follow-up patch if this is merged right away, or merge the comments in the next iteration of the patches. > Acked-by: Jingoo Han Thanks for taking the time to review this! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --3MHXEHrrXKLGx71o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJR5WrHAAoJEBx+YmzsjxAgmxsP/jqpdhyeGU8YY/k9BlSFHmDh iZeH16Ri2Awb6aJKDjYGLfR7IHMXwgSgX4mgCZMYOm46l3nqkHs2tTIkVQ54p6sT eWkTcqo95/vTtl/MKEiWSl4zjEyEgBgX2HKkosoVePls5m0suxbb3dMeNXoU5CN7 ZEIWf8NiZesnpdd+3tMl/mY7n2lcX5X0wYookluDKQARRfSkKuTZYioTY5SvXl2i 2QVYOZ3gi4A3fGJlsyumO8ow/hOBH1OQ4DxV7tRdC9AWMwsbsG/Li3fqqnDfRCTA k5NUfbWrJi7bRzy0n3oYJizKdD/jOxOgSNZHJX3oP9LPj2b3ads34D1fTa/WwQ1o eJ8vzFnCdnIgXpXRf0jrNiih9XSyS+h0CMHwYTAGwErdqDvL9dLeioQryO0rW6Du eQCgYrmGX3667UzDgOV0w4JRgmAtqYpJadCPAgrbnSYieCaV/AFadHH2SoOG/Pa5 JwE5o2yKX310SN4r/NDReEbyEMCGTaq1Gp/96lppKX4pflqdzGICKFFlwU36w5Mv Ey1erO05YpO0p8MjLH1ogLNlQ6MiPKGQcaTyV94TbAYXAUUnVmnJvZau5Dcaq1vD C672KwFqmvO/LxKCu+5JmPehT4AjL4iHeSA13tEXrhwj3bF+HL9vch7prE5voINJ kqTWOw/ZYfbG2lMh+gdo =sha7 -----END PGP SIGNATURE----- --3MHXEHrrXKLGx71o--