public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Philipp Matthias Hahn <pmhahn@pmhahn.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	alsa-devel@alsa-project.org,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>
Subject: Re: [alsa-devel] [BUG] 3.10.[01] modprobe snd-... hangs
Date: Tue, 16 Jul 2013 23:43:32 +0200	[thread overview]
Message-ID: <20130716214332.GA4139@pmhahn.de> (raw)
In-Reply-To: <s5h7ggqyezx.wl%tiwai@suse.de>

Hello,

On Tue, Jul 16, 2013 at 12:29:38PM +0200, Takashi Iwai wrote:
> Could you check the patch below?  It makes the code path involving
> with request_module asynchronous.

With the patch applied all modules were loaded successfully: no hanging
modprobe processes anymore.

Thank you for your support.

...
> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH] ALSA: seq-oss: Initialize MIDI clients asynchronously
> 
> The recent report showed that the initial registration of OSS
> sequencer clients stuck at loading the sound modules, which involves
> with request_module() at the init phase.  As a workaround, call the
> registration part asynchronously.  (And, this is a better approache
> irrespective of the hang fix.)
> 
> Reported-by: Philipp Matthias Hahn <pmhahn@pmhahn.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/core/seq/oss/seq_oss_init.c | 16 +++++++++++++---
>  sound/core/seq/oss/seq_oss_midi.c |  2 +-
>  2 files changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_init.c b/sound/core/seq/oss/seq_oss_init.c
> index e3cb46f..b3f39b5 100644

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@pmhahn.de

  reply	other threads:[~2013-07-16 21:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 18:20 [BUG] 3.10.[01] modprobe snd-... hangs Philipp Matthias Hahn
2013-07-16  5:41 ` Rusty Russell
2013-07-16  6:42   ` Lucas De Marchi
2013-07-16  6:43   ` [alsa-devel] " Takashi Iwai
2013-07-16  7:49     ` Damien Wyart
2013-07-16  8:28     ` Philipp Hahn
2013-07-16 10:29       ` Takashi Iwai
2013-07-16 21:43         ` Philipp Matthias Hahn [this message]
2013-07-16 16:03       ` Lucas De Marchi
2013-07-17  0:00         ` Rusty Russell
2013-07-17  7:15           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130716214332.GA4139@pmhahn.de \
    --to=pmhahn@pmhahn.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=rusty@rustcorp.com.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox