public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: linux-usb <linux-usb@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xhci: Correct misplaced newlines
Date: Tue, 16 Jul 2013 21:34:16 -0700	[thread overview]
Message-ID: <20130717043416.GA14392@xanatos> (raw)
In-Reply-To: <1374027959.1949.65.camel@joe-AO722>

Thanks Joe, I'll apply this to my tree after the merge window closes.

Sarah Sharp

On Tue, Jul 16, 2013 at 07:25:59PM -0700, Joe Perches wrote:
> Logging messages end in newlines, not have
> them put in the middle of messages.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/usb/host/xhci.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 2c49f00..87b5e65 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -3075,8 +3075,8 @@ static u32 xhci_calculate_no_streams_bitmask(struct xhci_hcd *xhci,
>  		/* Are streams already being freed for the endpoint? */
>  		if (ep_state & EP_GETTING_NO_STREAMS) {
>  			xhci_warn(xhci, "WARN Can't disable streams for "
> -					"endpoint 0x%x\n, "
> -					"streams are being disabled already.",
> +					"endpoint 0x%x, "
> +					"streams are being disabled already\n",
>  					eps[i]->desc.bEndpointAddress);
>  			return 0;
>  		}
> @@ -3084,8 +3084,8 @@ static u32 xhci_calculate_no_streams_bitmask(struct xhci_hcd *xhci,
>  		if (!(ep_state & EP_HAS_STREAMS) &&
>  				!(ep_state & EP_GETTING_STREAMS)) {
>  			xhci_warn(xhci, "WARN Can't disable streams for "
> -					"endpoint 0x%x\n, "
> -					"streams are already disabled!",
> +					"endpoint 0x%x, "
> +					"streams are already disabled!\n",
>  					eps[i]->desc.bEndpointAddress);
>  			xhci_warn(xhci, "WARN xhci_free_streams() called "
>  					"with non-streams endpoint\n");
> @@ -4353,7 +4353,7 @@ static u16 xhci_get_timeout_no_hub_lpm(struct usb_device *udev,
>  				state_name, sel);
>  	else
>  		dev_dbg(&udev->dev, "Device-initiated %s disabled "
> -				"due to long PEL %llu\n ms",
> +				"due to long PEL %llu ms\n",
>  				state_name, pel);
>  	return USB3_LPM_DISABLED;
>  }
> 
> 

      reply	other threads:[~2013-07-17  4:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17  2:25 [PATCH] xhci: Correct misplaced newlines Joe Perches
2013-07-17  4:34 ` Sarah Sharp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717043416.GA14392@xanatos \
    --to=sarah.a.sharp@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox