From: Sascha Hauer <s.hauer@pengutronix.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: drm/imx: drop "select OF_VIDEOMODE"
Date: Wed, 17 Jul 2013 10:23:55 +0200 [thread overview]
Message-ID: <20130717082355.GC10380@pengutronix.de> (raw)
In-Reply-To: <1373801388.1370.15.camel@x61.thuisdomein>
On Sun, Jul 14, 2013 at 01:29:48PM +0200, Paul Bolle wrote:
> Commit ac4c1a9b33 ("staging: drm/imx: Add LDB support") added the
> DRM_IMX_LDB Kconfig entry. That entry selects OF_VIDEOMODE. But there is
> no Kconfig symbol named OF_VIDEOMODE. The select statement for that
> symbol is a nop. Drop it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Not tested!
>
> 1) Perhaps OF_VIDEOMODE was selected because this commit added an
> include of <video/of_videomode>. But the functionality of that header
> requires the Kconfig symbol VIDEOMODE_HELPERS. The commit didn't use
> that Kconfig symbol.
>
> The again, as far as I can tell, the drm/imx code doesn't actually use
> the videomode of-helper. So it seems the include of <video/of_videomode>
> isn't needed anyway.
Looks all good.
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2013-07-17 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 11:29 [PATCH] staging: drm/imx: drop "select OF_VIDEOMODE" Paul Bolle
2013-07-17 8:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717082355.GC10380@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pebolle@tiscali.nl \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).