[PATCH] staging: drm/imx: drop "select OF_VIDEOMODE"

[PATCH] staging: drm/imx: drop "select OF_VIDEOMODE"

[Paul Bolle]

Commit ac4c1a9b33 ("staging: drm/imx: Add LDB support") added the
DRM_IMX_LDB Kconfig entry. That entry selects OF_VIDEOMODE. But there is
no Kconfig symbol named OF_VIDEOMODE. The select statement for that
symbol is a nop. Drop it.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Not tested!

1) Perhaps OF_VIDEOMODE was selected because this commit added an
include of <video/of_videomode>. But the functionality of that header
requires the Kconfig symbol VIDEOMODE_HELPERS. The commit didn't use
that Kconfig symbol.

The again, as far as I can tell, the drm/imx code doesn't actually use
the videomode of-helper. So it seems the include of <video/of_videomode>
isn't needed anyway.

 drivers/staging/imx-drm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig
index 2233905..bd0f2fd 100644
--- a/drivers/staging/imx-drm/Kconfig
+++ b/drivers/staging/imx-drm/Kconfig
@@ -33,7 +33,6 @@ config DRM_IMX_TVE
 config DRM_IMX_LDB
 	tristate "Support for LVDS displays"
 	depends on DRM_IMX
-	select OF_VIDEOMODE
 	help
 	  Choose this to enable the internal LVDS Display Bridge (LDB)
 	  found on i.MX53 and i.MX6 processors.
-- 
1.8.1.4

Re: [PATCH] staging: drm/imx: drop "select OF_VIDEOMODE"

[Sascha Hauer]

On Sun, Jul 14, 2013 at 01:29:48PM +0200, Paul Bolle wrote:
> Commit ac4c1a9b33 ("staging: drm/imx: Add LDB support") added the
> DRM_IMX_LDB Kconfig entry. That entry selects OF_VIDEOMODE. But there is
> no Kconfig symbol named OF_VIDEOMODE. The select statement for that
> symbol is a nop. Drop it.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Not tested!
> 
> 1) Perhaps OF_VIDEOMODE was selected because this commit added an
> include of <video/of_videomode>. But the functionality of that header
> requires the Kconfig symbol VIDEOMODE_HELPERS. The commit didn't use
> that Kconfig symbol.
> 
> The again, as far as I can tell, the drm/imx code doesn't actually use
> the videomode of-helper. So it seems the include of <video/of_videomode>
> isn't needed anyway.

Looks all good.

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |