From: Benjamin LaHaise <bcrl@kvack.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Gu Zheng <guz.fnst@cn.fujitsu.com>,
linux-aio@kvack.org
Subject: Re: linux-next: build failure after merge of the final tree (aio tree related)
Date: Wed, 17 Jul 2013 09:46:39 -0400 [thread overview]
Message-ID: <20130717134639.GC19643@kvack.org> (raw)
In-Reply-To: <20130717134124.23192f8c9bcc29b07f57743f@canb.auug.org.au>
Hello Stephen, (actually a greeting this time!)
On Wed, Jul 17, 2013 at 01:41:24PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> fs/aio.c: In function 'aio_migratepage':
> fs/aio.c:196:2: error: implicit declaration of function 'migrate_page_move_mapping' [-Werror=implicit-function-declaration]
> rc = migrate_page_move_mapping(mapping, new, old, NULL, mode);
> ^
>
> Caused by commit 36bc08cc0170 ("fs/aio: Add support to aio ring pages
> migration"). The declaration of migrate_page_move_mapping() in
> linux/migrate.h is protected by CONFIG_MIGRATION - its use in fs/aio.c is
> not. So the usage needs to be protected, or there needs to be a dummy
> version in linux/migrate.h
I have added and tested a fix for this issue and pushed it out to my
tree. Thanks for the report -- I'll try to be a bit more careful.
-ben
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
--
"Thought is the essence of where you are now."
prev parent reply other threads:[~2013-07-17 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 3:41 linux-next: build failure after merge of the final tree (aio tree related) Stephen Rothwell
2013-07-17 13:46 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717134639.GC19643@kvack.org \
--to=bcrl@kvack.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).