* linux-next: build failure after merge of the final tree (aio tree related)
@ 2013-07-17 3:41 Stephen Rothwell
2013-07-17 13:46 ` Benjamin LaHaise
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2013-07-17 3:41 UTC (permalink / raw)
To: Benjamin LaHaise; +Cc: linux-next, linux-kernel, Gu Zheng
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:
fs/aio.c: In function 'aio_migratepage':
fs/aio.c:196:2: error: implicit declaration of function 'migrate_page_move_mapping' [-Werror=implicit-function-declaration]
rc = migrate_page_move_mapping(mapping, new, old, NULL, mode);
^
Caused by commit 36bc08cc0170 ("fs/aio: Add support to aio ring pages
migration"). The declaration of migrate_page_move_mapping() in
linux/migrate.h is protected by CONFIG_MIGRATION - its use in fs/aio.c is
not. So the usage needs to be protected, or there needs to be a dummy
version in linux/migrate.h
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: build failure after merge of the final tree (aio tree related)
2013-07-17 3:41 linux-next: build failure after merge of the final tree (aio tree related) Stephen Rothwell
@ 2013-07-17 13:46 ` Benjamin LaHaise
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin LaHaise @ 2013-07-17 13:46 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Gu Zheng, linux-aio
Hello Stephen, (actually a greeting this time!)
On Wed, Jul 17, 2013 at 01:41:24PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> fs/aio.c: In function 'aio_migratepage':
> fs/aio.c:196:2: error: implicit declaration of function 'migrate_page_move_mapping' [-Werror=implicit-function-declaration]
> rc = migrate_page_move_mapping(mapping, new, old, NULL, mode);
> ^
>
> Caused by commit 36bc08cc0170 ("fs/aio: Add support to aio ring pages
> migration"). The declaration of migrate_page_move_mapping() in
> linux/migrate.h is protected by CONFIG_MIGRATION - its use in fs/aio.c is
> not. So the usage needs to be protected, or there needs to be a dummy
> version in linux/migrate.h
I have added and tested a fix for this issue and pushed it out to my
tree. Thanks for the report -- I'll try to be a bit more careful.
-ben
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
--
"Thought is the essence of where you are now."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-17 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 3:41 linux-next: build failure after merge of the final tree (aio tree related) Stephen Rothwell
2013-07-17 13:46 ` Benjamin LaHaise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).