linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V7 01/14] perf tools: add debug prints
Date: Wed, 17 Jul 2013 17:10:00 -0300	[thread overview]
Message-ID: <20130717201000.GB31906@ghostprotocols.net> (raw)
In-Reply-To: <1374064994-17810-2-git-send-email-adrian.hunter@intel.com>

Em Wed, Jul 17, 2013 at 03:43:01PM +0300, Adrian Hunter escreveu:
> It is useful to see the arguments to perf_event_open
> and whether the perf events ring buffer was mmapped
> per-cpu or per-thread.  That information will now be
> displayed when verbose is 2 i.e option -vv
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Please use 'perf test' before sending patchkits:

[root@zoo ~]# perf test
<SNIP>
14: Test matching and linking multiple hists               : Ok
15: Try 'use perf' in python, checking link problems       : FAILED!
16: Test breakpoint overflow signal handler                : FAILED!
17: Test breakpoint overflow sampling                      : FAILED!
18: Test number of exit event of a simple workload         : Ok
19: Test software clock events have valid period values    : Ok
[root@zoo ~]# 
[root@zoo ~]# perf test 15
15: Try 'use perf' in python, checking link problems       : FAILED!
[root@zoo ~]# set -o vi
[root@zoo ~]# perf test -v 15
15: Try 'use perf' in python, checking link problems       :
--- start ---
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: /tmp/build/perf/python/perf.so: undefined symbol: verbose
---- end ----
Try 'use perf' in python, checking link problems: FAILED!
[root@zoo ~]# 


	The python binding only links a subset of the tools/perf/util/ objects
and is an exercise in trying to modularize the functions so that we don't
drag the whole world into it or in any other libraries we come up with.

	Perhaps in this case we need to make the 'verbose' variable
available in one of the object files already in the link kit for the
python binding or plain pass verbose as a parameter to this function. I
tend to prefer the later, to avoid having a tools/utils wide global.

- Arnaldo

  reply	other threads:[~2013-07-17 20:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 12:43 [PATCH V7 00/14] perf tools: some fixes and tweaks Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 01/14] perf tools: add debug prints Adrian Hunter
2013-07-17 20:10   ` Arnaldo Carvalho de Melo [this message]
2013-07-18 10:44     ` Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 02/14] perf tools: allow non-matching sample types Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 03/14] perf tools: add pid to struct thread Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 04/14] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 05/14] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 06/14] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 07/14] perf tools: remove references to struct ip_event Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 08/14] perf tools: move " Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 09/14] perf: Update perf_event_type documentation Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 10/14] perf: make events stream always parsable Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 11/14] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 12/14] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 13/14] perf tools: add a function to calculate sample event size Adrian Hunter
2013-07-17 12:43 ` [PATCH V7 14/14] perf tools: add a sample parsing test Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717201000.GB31906@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).