From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>, PaX Team <pageexec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/urgent] x86: Make sure IDT is page aligned
Date: Thu, 18 Jul 2013 09:05:55 +0200 [thread overview]
Message-ID: <20130718070555.GC17622@gmail.com> (raw)
In-Reply-To: <51E6F73F.3000202@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> On 07/17/2013 11:57 AM, Yinghai Lu wrote:
> >
> > Hi, Peter,
> >
> > Any reason for why following changelog get dropped?
> >
> > ---
> > v5:
> > - add comments to all IDTs about alignment reasoning, suggested by Linus
> > v4:
> > - rework using __page_aligned_bss, suggested by Yinghai LU
> > - move all the other IDT variables as well, suggested by HPA
> > v3:
> > - merge 32-bit and 64-bit idt_table definition
> > v2:
> > - 32-bit was already aligned
> > ---
> >
> > That at least would help us to check if you apply the right version.
> >
>
> Procedurally, the changelogs don't belong in commit messages. I tend to
> leave them in if they are particularly illustrative or if the commit
> message only makes sense with the additional context, but neither of
> those is really ideal.
>
> Technically, because of the --- line which indicates the end of the
> commit message.
Furthermote, the -tip notification email will generally email-thread on
lkml to the patch submission that was applied.
That is a more robust indication of which submission was applied than any
changelog detail.
Thanks,
Ingo
next prev parent reply other threads:[~2013-07-18 7:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 18:34 [PATCH v5] x86: make sure IDT is page aligned Kees Cook
2013-07-16 18:58 ` Steven Rostedt
2013-07-16 20:21 ` Yinghai Lu
2013-07-16 20:28 ` Kees Cook
2013-07-16 20:33 ` Steven Rostedt
2013-07-16 20:43 ` H. Peter Anvin
2013-07-16 20:47 ` Kees Cook
2013-07-16 22:03 ` H. Peter Anvin
2013-07-16 22:13 ` Yinghai Lu
2013-07-16 22:16 ` H. Peter Anvin
2013-07-16 23:39 ` Yinghai Lu
2013-07-16 23:43 ` H. Peter Anvin
2013-07-16 23:59 ` Yinghai Lu
2013-07-16 22:33 ` [tip:x86/urgent] x86: Make " tip-bot for Kees Cook
2013-07-17 18:57 ` Yinghai Lu
2013-07-17 19:57 ` H. Peter Anvin
2013-07-18 7:05 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-12 22:50 [PATCH v3] x86: make " Kees Cook
2013-07-13 3:21 ` [tip:x86/urgent] x86: Make " tip-bot for Kees Cook
2013-07-13 20:39 ` Yinghai Lu
2013-07-13 21:34 ` Yinghai Lu
2013-07-15 18:09 ` H. Peter Anvin
2013-07-15 18:37 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718070555.GC17622@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=pageexec@gmail.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).