Re: [PATCH] perf tools: Fix 'make tools/perf'

[Arnaldo Carvalho de Melo <acme@infradead.org>]

Em Thu, Jul 18, 2013 at 02:19:24PM +0200, Robert Richter escreveu:
> Arnaldo,
> 
> I noticed you applied the patch to acme/perf/core, but it should be
> instead in urgent since mainline is broken.

I did it because there are alternative ways to build the tools that
don't require this fix, i.e. this is not _strictly_ needed to build the
tools.

What do you guys think: a case like this always needs to go to the
current release candidate? Ingo?

- Arnaldo
 
> On 17.07.13 18:10:51, Robert Richter wrote:
> > On 17.07.13 17:40:01, Borislav Petkov wrote:
> > > On Wed, Jul 17, 2013 at 12:31:18PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Humm, probably it will look at the top level 'install' target? There
> > > > was some discussion about this, right? Can you refresh my mind?
> 
> Now tested with:
> 
>  make O=... DESTDIR=... tools/perf
>  make O=... DESTDIR=... tools/perf_install
>  make O=... DESTDIR=... -C tools/ perf
>  make O=... DESTDIR=... -C tools/ perf_install
>  make O=... DESTDIR=... -C tools/perf
>  make O=... DESTDIR=... -C tools/perf install
>  make tools/perf
>  make DESTDIR=... tools/perf_install
>  make -C tools/ perf
>  make -C tools/ DESTDIR=... perf_install
>  make -C tools/perf
>  make -C tools/perf DESTDIR=... install
> 
> No issues noticed, accept that doc is built when running the 'install'
> target, not 'all'.
> 
> Will look at this.
> 
> We also should remove dependencies from install targets that trigger a
> rebuild since 'make install' is run as root. I had a conversation with
> Linus about this for building the arm kernel, but the same applies
> also for perf tools. I don't have the time for changing this now, but
> maybe in some weeks or so.
> 
> Thanks,
> 
> -Robert