From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, abbotti@mev.co.uk, oliver@schinagl.nl
Subject: Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups
Date: Thu, 18 Jul 2013 16:54:17 -0700 [thread overview]
Message-ID: <20130718235417.GA9538@roeck-us.net> (raw)
In-Reply-To: <1373843160-3990-1-git-send-email-gregkh@linuxfoundation.org>
On Sun, Jul 14, 2013 at 04:05:50PM -0700, Greg Kroah-Hartman wrote:
> Hi all,
>
> Here is the third iteration of the patchset to add better attribute
> group support to the driver core and sysfs.
>
> Others have now tested it, and we got 3 more patches fixing a warning
> that was showing up when binary attributes were in a group with no
> "normal" attributes, and some more helper macros were added and cleaned
> up.
>
> I've booted this successfully against 3.11-rc1 with no problems (am
> sending these from that machine.)
>
> Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later. I
> considered it, but that would also mean a BUS_PATTR() and the like, which I
> guess works, but I hate even a _hint_ of "Hungarian" notation, which this
> implies.
>
> Anyone else have a better name for this macro:
> #define DEVICE_PATTR(_name) &dev_attr_##_name.attr
> that they can think of? It will cut down on the typing done for
> attribute lists.
>
> changes from v3:
> - tested by Guenter
> - patches from Oliver added
> - refreshed on 3.11-rc1 (minor fuzz)
> - Ian glanced at them.
>
> changes from v2:
> - actually boots
> - 7th patch added properly
> - added BUS_ATTR, CLASS_ATTR, and DRIVER_ATTR RW and RO macros
> to help with converting code to use attributes properly.
>
Hi Greg,
thanks a lot for this series of patches, and for pushing it upstream.
Do you by any chance have a repository for the cleanup patches depending on this
series ? It looks like a good area to get involved with when I am tired/annoyed
by my other work, but I would not want to duplicate your work.
Thanks,
Guenter
next prev parent reply other threads:[~2013-07-18 23:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 23:05 [PATCH v3 01/10] Driver core and sysfs changes for attribute groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 01/10] sysfs.h: add __ATTR_RW() macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 02/10] sysfs.h: add ATTRIBUTE_GROUPS() macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 03/10] sysfs.h: add BIN_ATTR macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 04/10] driver core: device.h: add RW and RO attribute macros Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 05/10] sysfs: add support for binary attributes in groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 06/10] sysfs: prevent warning when only using binary attributes Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 07/10] driver core: Introduce device_create_groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 08/10] driver core: add default groups to struct class Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 09/10] sysfs: add more helper macro's for (bin_)attribute(_groups) Greg Kroah-Hartman
2013-07-14 23:06 ` [PATCH 10/10] sysfs: use file mode defines from stat.h Greg Kroah-Hartman
2013-07-15 0:27 ` [PATCH v3 01/10] Driver core and sysfs changes for attribute groups Stephen Rothwell
2013-07-15 0:32 ` Greg Kroah-Hartman
2013-07-15 9:41 ` Ian Abbott
2013-07-15 9:56 ` Ian Abbott
2013-07-18 23:54 ` Guenter Roeck [this message]
2013-07-19 0:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718235417.GA9538@roeck-us.net \
--to=linux@roeck-us.net \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox