From: Dan Carpenter <dan.carpenter@oracle.com>
To: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Eric Dumazet <edumazet@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] relay: fix timer madness
Date: Sat, 20 Jul 2013 01:45:03 +0300 [thread overview]
Message-ID: <20130719224502.GA5687@mwanda> (raw)
In-Reply-To: <51DCC48E.8050003@huawei.com>
On Wed, Jul 10, 2013 at 10:18:54AM +0800, zhangwei(Jovi) wrote:
> @@ -339,6 +339,10 @@ static void wakeup_readers(unsigned long data)
> {
> struct rchan_buf *buf = (struct rchan_buf *)data;
> wake_up_interruptible(&buf->read_wait);
> + /*
> + * Stupid polling for now:
> + */
> + mod_timer(&buf->timer, HZ / 10);
mod_timer() takes an offset so probably "jiffies + HZ / 10" was
intended here and also below. Certainly passing "HZ / 10" doesn't
make any kind of sense.
regards,
dan carpenter
prev parent reply other threads:[~2013-07-19 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 2:18 [PATCH V2] relay: fix timer madness zhangwei(Jovi)
2013-07-10 3:37 ` Li Zefan
2013-07-10 3:57 ` Andrew Morton
2013-07-19 22:45 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719224502.GA5687@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=edumazet@google.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox