From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lilis Iskandar <veeableful@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: Qos: Fix some coding style issues
Date: Tue, 23 Jul 2013 12:54:16 +0300 [thread overview]
Message-ID: <20130723095416.GM5585@mwanda> (raw)
In-Reply-To: <1374571229.15906.3.camel@desktop>
Hi hi,
Welcome first time submitter newbie. :) The tradition is to reject
first time code submissions in the meanest and grumpiest way
possible.
On Tue, Jul 23, 2013 at 05:20:29PM +0800, Lilis Iskandar wrote:
> >From a2f8b299baee0e075d548d2bbf77619373035446 Mon Sep 17 00:00:00 2001
> From: Lilis Iskandar <veeableful@gmail.com>
> Date: Tue, 23 Jul 2013 17:08:37 +0800
> Subject: [PATCH] Staging: bcm: Qos: Fix some coding style issues
This header stuff is not needed. See if you can figure out how to
get rid of it.
You are fixing too many kinds of problems at once so the patch is
impossible to review. Please break it up into one kind of issue
per patch.
> - if(FALSE == (bClassificationSucceed =
> + if (FALSE == (bClassificationSucceed =
> MatchSrcPort(pstClassifierRule,
> - ntohs((iphd->protocol == UDP)?
> - xprt_hdr->uhdr.source:xprt_hdr->thdr.source))))
> + ntohs((iphd->protocol == UDP)?
> + xprt_hdr->uhdr.source : xprt_hdr->thdr.source))))
> + {
> break;
> + }
I don't know why you are adding curly braces here but they don't
belong. Braces are explained in CodingStyle.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-23 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 9:20 [PATCH] Staging: bcm: Qos: Fix some coding style issues Lilis Iskandar
2013-07-23 9:54 ` Dan Carpenter [this message]
2013-07-23 10:10 ` Lilis Iskandar
2013-07-23 10:18 ` Dan Carpenter
2013-07-23 11:51 ` Lilis Iskandar
2013-07-23 15:11 ` Dan Carpenter
2013-07-23 16:42 ` Joe Perches
2013-07-23 18:25 ` Lilis Iskandar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723095416.GM5585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=veeableful@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox