From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Rob Herring <rob.herring@calxeda.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree-discuss@vger.kernel.org
Subject: Re: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage
Date: Tue, 23 Jul 2013 13:34:44 +0100 [thread overview]
Message-ID: <20130723123444.GW9858@sirena.org.uk> (raw)
In-Reply-To: <20130723104615.3696f1a9@armhf>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:
> + np = pdev->dev.of_node;
> + if (np) {
> + struct of_phandle_args clkspec;
> +
> + priv->burst = 128; /* might be 32 or 128 */
The comment says this needs to be variable (depending on what?) but it's
hard coded.
> + priv->clk = of_clk_get(np, 0); /* internal clock */
> + err = of_parse_phandle_with_args(np,
> + "clocks", "#clock-cells", 1,
> + &clkspec);
As others have pointed out if you need to change the clock get code
there's something wrong here, DT should be handled transparently by the
clock API.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-23 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:46 [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage Jean-Francois Moine
2013-07-23 8:53 ` Russell King - ARM Linux
2013-07-23 9:03 ` Lars-Peter Clausen
2013-07-23 9:08 ` [alsa-devel] " Sascha Hauer
2013-07-23 9:39 ` Russell King - ARM Linux
2013-07-23 9:48 ` Sascha Hauer
2013-07-23 12:34 ` Mark Brown [this message]
2013-07-23 12:59 ` Sebastian Hesselbarth
2013-07-23 13:20 ` Mark Brown
2013-07-23 13:30 ` Sebastian Hesselbarth
2013-07-23 13:50 ` Russell King - ARM Linux
2013-07-23 17:04 ` Mark Brown
2013-07-23 15:01 ` Mark Brown
2013-07-23 15:19 ` Russell King - ARM Linux
2013-07-23 17:16 ` Mark Brown
2013-07-23 15:34 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723123444.GW9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=perex@perex.cz \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox