public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
	Anish Singh <anish198519851985@gmail.com>
Subject: Re: [PATCH 8/8] watchdog: Remove hack to make full dynticks working
Date: Tue, 23 Jul 2013 14:44:02 +0200	[thread overview]
Message-ID: <20130723124400.GA10278@somewhere> (raw)
In-Reply-To: <20130723123331.GE126784@redhat.com>

On Tue, Jul 23, 2013 at 08:33:31AM -0400, Don Zickus wrote:
> On Tue, Jul 23, 2013 at 02:31:06AM +0200, Frederic Weisbecker wrote:
> > A perf event can be used without forcing the tick to
> > stay alive if it doesn't use a frequency but a sample
> > period and if it doesn't throttle (raise storm of events).
> > 
> > Since the lockup detector neither use a perf event frequency
> > nor should ever throttle due to its high period, it can now
> > run concurrently with the full dynticks feature.
> 
> Thanks.  Dumb question, I keep wondering if the lockup detector would be
> better or worse off if it used the perf event frequency as opposed to
> using a sample period?  The idea is it could follow the varying cpu
> frequencies better (and probably simplify some of the code too).
> 
> Acked-by: Don Zickus <dzickus@redhat.com>

Thanks!

IIRC we tried that and I believe the issue was that perf did not
support frequency below 1. So probably the limitation was that it had to
fire at least once per sec.

Also if you do that, we fall into the full dynticks problem again.

  reply	other threads:[~2013-07-23 12:44 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  0:30 [PATCH 0/8] perf: Finer grained full dynticks handling Frederic Weisbecker
2013-07-23  0:30 ` [PATCH 1/8] perf: Fix branch stack refcount leak on callchain init failure Frederic Weisbecker
2013-07-31  8:55   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 2/8] perf: Sanitize get_callchain_buffer() Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-08-01 13:01   ` [PATCH 2/8] " Jiri Olsa
2013-08-01 13:28     ` Frederic Weisbecker
2013-08-01 13:32       ` Jiri Olsa
2013-08-01 13:49         ` Frederic Weisbecker
2013-08-01 13:54           ` Jiri Olsa
2013-08-01 13:57             ` Frederic Weisbecker
2013-08-01 13:29   ` Jiri Olsa
2013-08-01 13:42     ` Frederic Weisbecker
2013-08-01 13:51       ` Jiri Olsa
2013-08-01 14:30         ` Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 3/8] perf: Gather event accounting code Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] perf: Factor out event accounting code to account_event()/__free_event() tip-bot for Frederic Weisbecker
2013-08-01 13:13   ` [PATCH 3/8] perf: Gather event accounting code Jiri Olsa
2013-08-01 13:30     ` Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 4/8] perf: Split per cpu " Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] perf: Split the per-cpu accounting part of the " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 5/8] perf: Migrate per cpu event accounting Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 6/8] perf: Account freq events per cpu Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-08-01 12:46   ` [PATCH 6/8] " Jiri Olsa
2013-08-01 12:48     ` Jiri Olsa
2013-08-01 13:31     ` Peter Zijlstra
2013-08-01 13:35       ` Peter Zijlstra
2013-08-01 13:39       ` Jiri Olsa
2013-08-01 13:56         ` Peter Zijlstra
2013-08-01 13:55       ` Frederic Weisbecker
2013-08-01 14:03         ` Peter Zijlstra
2013-08-01 14:06           ` Peter Zijlstra
2013-08-01 14:21             ` Frederic Weisbecker
2013-08-01 14:40               ` Peter Zijlstra
2013-08-02 16:25                 ` Frederic Weisbecker
2013-08-01 14:19           ` Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 7/8] perf: Finer grained full dynticks kick Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] perf: Implement finer " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 8/8] watchdog: Remove hack to make full dynticks working Frederic Weisbecker
2013-07-23 12:33   ` Don Zickus
2013-07-23 12:44     ` Frederic Weisbecker [this message]
2013-07-23 12:45     ` Peter Zijlstra
2013-07-31  8:57   ` [tip:perf/core] watchdog: Make it work under full dynticks tip-bot for Frederic Weisbecker
2013-07-25  9:59 ` [PATCH 0/8] perf: Finer grained full dynticks handling Peter Zijlstra
2013-07-25 14:02   ` Frederic Weisbecker
2013-07-25 16:29     ` Peter Zijlstra
2013-07-25 20:07       ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723124400.GA10278@somewhere \
    --to=fweisbec@gmail.com \
    --cc=acme@redhat.com \
    --cc=anish198519851985@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox