From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
eranian@google.com
Subject: Re: [PATCH] perf, x86: Enable PEBS mode automatically for mem-{loads,stores} v3
Date: Tue, 23 Jul 2013 21:14:13 +0200 [thread overview]
Message-ID: <20130723191413.GS6123@two.firstfloor.org> (raw)
In-Reply-To: <20130723165739.GD27075@twins.programming.kicks-ass.net>
On Tue, Jul 23, 2013 at 06:57:39PM +0200, Peter Zijlstra wrote:
> On Tue, Jul 23, 2013 at 06:13:34PM +0200, Andi Kleen wrote:
> > On Tue, Jul 23, 2013 at 10:38:34AM +0200, Peter Zijlstra wrote:
> > > On Thu, Jul 18, 2013 at 04:03:39PM -0700, Andi Kleen wrote:
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > >
> > > > [The patch to enable this in the user tools has been sent separately]
> > > >
> > > > With the earlier patches to automatically try cpu// and add
> > > > a precise sys attribute, we can now enable PEBS for the mem-loads,
> > > > mem-stores events everywhere.
> > > >
> > > > This allows to use
> > > >
> > > > perf record -e mem-loads ...
> > > >
> > > > instead of
> > > >
> > > > perf record -e cpu/mem-loads/p ...
> > > >
> > > > Always use precise=2 even though it is costly pre-Haswell
> > >
> > > This Changelog fails to give a reason _why_ we'd want to do this.
> >
> > The first is much nicer to type and understand? Just in the spirit of
> > making perf easier to use.
>
> And here I was thinking that maybe these events don't make sense without
> pebs or so. But no, rather than giving an actual useful reason you'd
> have me look things up myself. *sigh*
You can use them without PEBS, but they're much more useful with PEBS
(e.g. due to skid or if you want the address or data source, although
you can also use perf mem for the later)
I think PEBS on is a better default here.
BTW I should add i have some other events (for HSW TSX) that would
really like a PEBS default. That was the original motivation,
but then I realized it makes other things nicer too.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2013-07-23 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 23:03 [PATCH] perf, x86: Enable PEBS mode automatically for mem-{loads,stores} v3 Andi Kleen
2013-07-19 7:46 ` Ingo Molnar
2013-07-23 8:38 ` Peter Zijlstra
2013-07-23 16:13 ` Andi Kleen
2013-07-23 16:57 ` Peter Zijlstra
2013-07-23 17:46 ` Stephane Eranian
2013-07-23 19:14 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723191413.GS6123@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox