* Re: [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue.
[not found] <1373301228-18694-1-git-send-email-neonsync1@gmail.com>
@ 2013-07-23 21:50 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-07-23 21:50 UTC (permalink / raw)
To: Aldo Iljazi; +Cc: devel, linux-kernel
On Mon, Jul 08, 2013 at 07:33:48PM +0300, Aldo Iljazi wrote:
> Fixed a coding style issue, specifically checkpatch.pl complain:
> ossiRelease.c:27: WARNING: line over 80 characters
>
> Signed-off-by: Aldo Iljazi <neonsync1@gmail.com>
> ---
> drivers/staging/cxt1e1/ossiRelease.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/cxt1e1/ossiRelease.c b/drivers/staging/cxt1e1/ossiRelease.c
> index f17a902..35575bf 100644
> --- a/drivers/staging/cxt1e1/ossiRelease.c
> +++ b/drivers/staging/cxt1e1/ossiRelease.c
> @@ -24,6 +24,7 @@
> *-----------------------------------------------------------------------------
> */
>
> -char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B, Copyright (c) 2008 One Stop Systems$";
> +char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B, "
> +"Copyright (c) 2008 One Stop Systems$";
No, please fix this correctly, by just removing it entirely, it's not
needed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue.
@ 2013-07-08 16:40 Aldo Iljazi
2013-07-08 16:52 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Aldo Iljazi @ 2013-07-08 16:40 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Aldo Iljazi
Fixed a coding style issue, specifically checkpatch.pl complain:
ossiRelease.c:27: WARNING: line over 80 characters
Signed-off-by: Aldo Iljazi <neonsync1@gmail.com>
---
drivers/staging/cxt1e1/ossiRelease.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/ossiRelease.c b/drivers/staging/cxt1e1/ossiRelease.c
index f17a902..35575bf 100644
--- a/drivers/staging/cxt1e1/ossiRelease.c
+++ b/drivers/staging/cxt1e1/ossiRelease.c
@@ -24,6 +24,7 @@
*-----------------------------------------------------------------------------
*/
-char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B, Copyright (c) 2008 One Stop Systems$";
+char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B, "
+"Copyright (c) 2008 One Stop Systems$";
/*** End-of-File ***/
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue.
2013-07-08 16:40 Aldo Iljazi
@ 2013-07-08 16:52 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-07-08 16:52 UTC (permalink / raw)
To: Aldo Iljazi; +Cc: devel, linux-kernel
On Mon, Jul 08, 2013 at 07:40:17PM +0300, Aldo Iljazi wrote:
> Fixed a coding style issue, specifically checkpatch.pl complain:
> ossiRelease.c:27: WARNING: line over 80 characters
And it's wrong, this fix is not the correct way to do this.
I'd recommend just removing it entirely, as it doesn't make much sense
anymore now that the driver is in the kernel tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-23 21:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1373301228-18694-1-git-send-email-neonsync1@gmail.com>
2013-07-23 21:50 ` [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue Greg KH
2013-07-08 16:40 Aldo Iljazi
2013-07-08 16:52 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox