Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver

Mark Brown
2013-07-24T14:40:09Z

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

On Wed, Jul 24, 2013 at 11:51:45AM +0200, Steffen Trumtrar wrote:
> On Wed, Jul 24, 2013 at 10:42:28AM +0100, Mark Brown wrote:

> > > static struct regulator_ops pfuze100_fixed_regulator_ops = {
> > > .list_voltage = regulator_list_voltage_linear,
> > > + .set_voltage_sel = regulator_set_voltage_sel_regmap,
> > > };

> > This doesn't make much sense, you're adding a set voltage operation to a
> > fixed voltage regulator...

> Hm, okay, sounds reasonable. But if I don't, VREFDDR isn't registered because
> _regulator_do_set_voltage returns with -EINVAL.
> So, I probably just fixed a symptom and not the cause.

Yes, the obvious question is why we're trying to set a voltage on a
regulator which can't change voltage. Usually this is a result of
setting a constraint that tries to force the voltage.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]