From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223Ab3GXJv5 (ORCPT ); Wed, 24 Jul 2013 05:51:57 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:45500 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587Ab3GXJv4 (ORCPT ); Wed, 24 Jul 2013 05:51:56 -0400 Date: Wed, 24 Jul 2013 11:51:45 +0200 From: Steffen Trumtrar To: Mark Brown Cc: Robin Gong , shawn.guo@linaro.org, grant.likely@linaro.org, rob.herring@calxeda.com, rob@landley.net, lgirdwood@gmail.com, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver Message-ID: <20130724095145.GE4332@pengutronix.de> References: <1374398247-11384-1-git-send-email-b38343@freescale.com> <20130724083041.GC4332@pengutronix.de> <20130724094228.GY9858@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130724094228.GY9858@sirena.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:45:57 up 40 days, 21:56, 26 users, load average: 0.11, 0.24, 0.14 User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5054:ff:fec0:8e10 X-SA-Exim-Mail-From: str@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 24, 2013 at 10:42:28AM +0100, Mark Brown wrote: > On Wed, Jul 24, 2013 at 10:30:41AM +0200, Steffen Trumtrar wrote: > > On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote: > > > > > static struct regulator_ops pfuze100_fixed_regulator_ops = { > > .list_voltage = regulator_list_voltage_linear, > > + .set_voltage_sel = regulator_set_voltage_sel_regmap, > > }; > > This doesn't make much sense, you're adding a set voltage operation to a > fixed voltage regulator... Hm, okay, sounds reasonable. But if I don't, VREFDDR isn't registered because _regulator_do_set_voltage returns with -EINVAL. So, I probably just fixed a symptom and not the cause. Thanks, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |