public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, Peng Tao <tao.peng@emc.com>,
	Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults
Date: Wed, 24 Jul 2013 13:07:30 -0700	[thread overview]
Message-ID: <20130724200730.GA22161@kroah.com> (raw)
In-Reply-To: <1374689299-10126-4-git-send-email-bergwolf@gmail.com>

On Thu, Jul 25, 2013 at 02:08:19AM +0800, Peng Tao wrote:
> From: Peng Tao <tao.peng@emc.com>
> 
> Should be y instead of true.
> 
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Cc: Andreas Dilger <andreas.dilger@intel.com>
> Signed-off-by: Peng Tao <tao.peng@emc.com>
> ---
>  drivers/staging/lustre/lustre/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index 9ae7fa8..e3b3c74 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
>  config LUSTRE_TRANSLATE_ERRNOS
>  	bool
>  	depends on LUSTRE_FS && !X86
> -	default true
> +	default y

Why is the default for this going to be 'y'?  That should only be for
things that keep the machine from booting.

If this is something you always want to do, then why make it an option
at all?

Given that there is no documentation for what this option is, and why
people should always turn it on, I can't accept this patch, sorry.

greg k-h

  reply	other threads:[~2013-07-24 20:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 18:08 [PATCH-RESEND 0/3] staging/lustre: Intel tree sync and two fixups Peng Tao
2013-07-24 18:08 ` [PATCH-RESEND 1/3] staging/lustre/obdclass: add obd_target.h Peng Tao
2013-07-24 18:08 ` [PATCH-RESEND 2/3] staging/lustre: fix build on non-x86 Peng Tao
2013-07-24 18:08 ` [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults Peng Tao
2013-07-24 20:07   ` Greg Kroah-Hartman [this message]
2013-07-25  2:39     ` Peng Tao
  -- strict thread matches above, loose matches on Subject: below --
2013-07-24 18:00 [PATCH-RESEND 0/3] staging/lustre: Intel tree sync and two fixups Peng Tao
2013-07-24 18:00 ` [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults Peng Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724200730.GA22161@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=bergwolf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tao.peng@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox